Hello,
This patch fixes the documentation for kickstart API when a kickstart
is not found.
Cheers,
Marcelo Moreira de Mello
--
Marcelo Moreira de Mello
RHCA RHCSS RHCVA
Software Maintenance Engineer/SEG
gpg id: 2048R/FDB110E5
gpg fingerprint: 3BE7 EF71 4DD7 6812 D309 8F18 BD42 D095 FDB1 10E5
From: Marcelo Moreira de Mello <mme...@redhat.com>
Date: Tue, 31 May 2011 13:37:11 -0400
Subject: [PATCH] rhbz#709365 - fixed delete kickstart API docs
---
.../xmlrpc/kickstart/KickstartHandler.java | 13 ++++---------
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git
a/java/code/src/com/redhat/rhn/frontend/xmlrpc/kickstart/KickstartHandler.java
b/java/code/src/com/redhat/rhn/frontend/xmlrpc/kickstart/KickstartHandler.java
index ea21642..3f8e9b7 100644
---
a/java/code/src/com/redhat/rhn/frontend/xmlrpc/kickstart/KickstartHandler.java
+++
b/java/code/src/com/redhat/rhn/frontend/xmlrpc/kickstart/KickstartHandler.java
@@ -375,14 +375,13 @@ public class KickstartHandler extends BaseHandler {
* delete a kickstart profile
* @param sessionKey the session key
* @param ksLabel the kickstart to remove an ip range from
- * @return 1 on removal, 0 if not found, exception otherwise
+ * @return 1 if sucessful, exception otherwise.
*
* @xmlrpc.doc Delete a kickstart profile
* @xmlrpc.param #session_key()
* @xmlrpc.param #param_desc("string", "ksLabel", "The label of
* the kickstart profile you want to remove")
- * @xmlrpc.returntype int - 1 on successful deletion, 0 if kickstart
wasn't found
- * or couldn't be deleted.
+ * @xmlrpc.returntype #return_int_success()
*/
public int deleteProfile(String sessionKey, String ksLabel) {
User user = getLoggedInUser(sessionKey);
@@ -392,12 +391,8 @@ public class KickstartHandler extends BaseHandler {
KickstartData ksdata = lookupKsData(ksLabel, user.getOrg());
KickstartDeleteCommand com = new
KickstartDeleteCommand(ksdata.getId(), user);
ValidatorError error = com.store();
- if (error == null) {
- return 1;
- }
- else {
- return 0;
- }
+
+ return 1;
}
/**
--
1.5.5.6
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
