On Fri, Jun 03, 2011 at 06:10:32AM +0200, Andreas Rogge wrote:
> Change to osa_dispatcher.py to make sure there are no dangling
> transactions while sleeping in the main loop.
> The two queries executed in these functions implicitly start a
> transaction that is never committed.
> 
> ---
>  client/tools/osad/src/osa_dispatcher.py |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/client/tools/osad/src/osa_dispatcher.py 
> b/client/tools/osad/src/osa_dispatcher.py
> index 5d6397a..ff9ceee 100644
> --- a/client/tools/osad/src/osa_dispatcher.py
> +++ b/client/tools/osad/src/osa_dispatcher.py
> @@ -206,6 +206,7 @@ class Runner(jabber_lib.Runner):
>          h = rhnSQL.prepare(self._query_fetch_clients_to_be_pinged)
>          h.execute(online_id=online_id)
>          clients = h.fetchall_dict() or []
> +        rhnSQL.commit()
>          if not clients:
>              # Nothing to do
>              return
> @@ -332,6 +333,7 @@ class UpstreamServer(SocketServer.TCPServer):
>              log_debug(4, "Notifying", jabber_id, row['server_id'])
>              self.jabber_connection.send_message(jabber_id,
>                  jabber_lib.NS_RHN_MESSAGE_REQUEST_CHECKIN)
> +        rhnSQL.commit()

Thank you, committed to Spacewalk master as

        5ac15a79d42a4a334bf162957a3de5f8c0536f50.

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to