Hello Jan,
On Thu, 2011-06-16 at 16:38 +0200, Jan Pazdziora wrote:
> On Thu, Jun 02, 2011 at 07:30:23PM -0300, Marcelo Moreira de Mello wrote:
> >
> > Follow attached the patch which fixes the BZ#508936.
> >
> > At RHN Satellite/Spacewalk documentation, to be able to execute remote
> > commands, it must exists a file named "run" into
> > /etc/sysconfig/rhn/allowed-actions/scripts directory.
> >
> > This patch fixes remote commands only be executed if the file "run"
> > exists into allowed-actions/scripts directory. All the other files will
> > be ignored.
>
> While this patch might make the behaviour consistent with the
> documentation, it will likely break existing clients. If the client
> has a file 'all' and remote commands are working fine (and are
> expected to work), suddenly they will stop working.
Agreed.
>
> We really have to think about the upgrade implications.
>
> If I understand it correctly, your concern is that even if
>
> rhn-actions-control --disable-all
>
> is run and passes, it does not disable the option because it removes
> the other file. Well, for that, one possibility is to always remove
> both files when disabling.
Yes. I think that we can fix this issue, making the --disable-all option
remove the both files ('all' and 'run'). I'm working into this. I'll
post the patch ASAP.
Thank you regarding the guidelines.
Cheers,
Marcelo Moreira de Mello
>
> > To make it consistent, we also fixed KickstartFormatter.java, which now
> > appends into kickstart the 'run' instead 'all' into
> > /etc/sysconfig/rhn/allowed-actions directory when rendering the
> > kickstart file.
>
> Did you verify that even old RHN Tools packages (RHEL 5, RHEL 4) use
> both "run" and "all" file to enable the option? In other words, won't
> this Spacewalk change break behaviour of existing distributions that
> people might be kickstarting?
>
> > After patched, --report option works as expected (ignoring all the
> > other files created manually) and remote commands will be only executed
> > when a file "run" exists at allowed-action/scripts directory.
>
> Nack. I don't see an upgrade path for systems that already have the
> 'all' file and are happy that things work.
>
--
Marcelo Moreira de Mello
RHCA RHCSS RHCVA
Software Maintenance Engineer/SEG
gpg id: 2048R/FDB110E5
gpg fingerprint: 3BE7 EF71 4DD7 6812 D309 8F18 BD42 D095 FDB1 10E5
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
