Hello,

ChannelEditor.pm was updated to allow max channel name length as 256 [1] . But under com/redhat/rhn/manager/channel/CreateChannelCommand.java, it still has 64 as the CHANNEL_NAME_MAX_LENGTH.

With this, we can't create channels through spacewalk-create-channel command with length more than 64.

We also have a bugzilla for RHN Satellite - https://bugzilla.redhat.com/show_bug.cgi?id=646802 .

I have attached the proposed patch for this issue.

Regards,
Paresh

[1] http://git.fedorahosted.org/git/?p=spacewalk.git;a=commit;h=e33a7fb3ca327feb9fd393d47c2e9fbc064b1624
>From fb8f457939fc2ce1155662da14e060d8f722b662 Mon Sep 17 00:00:00 2001
From: Paresh Mutha <pmu...@redhat.com>
Date: Thu, 7 Apr 2011 15:41:19 +0530
Subject: [PATCH 2/2] Fix to have consistent channel name max length to 256
 Signed-off-by: Paresh Mutha <pmu...@redhat.com>

---
 .../rhn/manager/channel/CreateChannelCommand.java  |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git 
a/java/code/src/com/redhat/rhn/manager/channel/CreateChannelCommand.java 
b/java/code/src/com/redhat/rhn/manager/channel/CreateChannelCommand.java
index 163e12c..ab0213c 100644
--- a/java/code/src/com/redhat/rhn/manager/channel/CreateChannelCommand.java
+++ b/java/code/src/com/redhat/rhn/manager/channel/CreateChannelCommand.java
@@ -36,7 +36,7 @@ import java.util.regex.Pattern;
 public class CreateChannelCommand {
 
     public static final int CHANNEL_NAME_MIN_LENGTH = 6;
-    public static final int CHANNEL_NAME_MAX_LENGTH = 64;
+    public static final int CHANNEL_NAME_MAX_LENGTH = 256;
     public static final int CHANNEL_LABEL_MIN_LENGTH = 6;
 
     protected static final String CHANNEL_NAME_REGEX =
-- 
1.7.4

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to