Please,

 Note that probably there is more one typo: 

   if (c.size() > 100) {
-      LOG.error("Query exectued with Collection larger than 1000");
+      LOG.error("Query executed with Collection larger than 1000");
   }

 The condition tests when > 100 but the LOG.error shows "larger than
1000".  

 It seems that ERROR will be printed when searching larger than 1000. 

 We filled a BZ#725555 regarding this issue.  

 We cloned the BZ#725555 to Satellite, since a customer is hitting this
issue. 

 Follow the patch attached. Please, ignore the patch sent previously. 

 Cheers, 
mmello

 


On Mon, 2011-07-25 at 17:14 -0300, Marcelo Moreira de Mello wrote:
> Hello, 
> 
>  Follow attached a patch which fixes a typo (s/exectued/executed/g) at
> HibernateFactory.java. 
> 
>  Thank you! 
> 
> Cheers, 
> mmello
> 
> 
> _______________________________________________
> Spacewalk-devel mailing list
> Spacewalk-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-devel

-- 
Marcelo Moreira de Mello
RHCA RHCSS RHCVA 
Software Maintenance Engineer/SEG           

gpg id: 2048R/FDB110E5
gpg fingerprint: 3BE7 EF71 4DD7 6812 D309  8F18 BD42 D095 FDB1 10E5
From: Marcelo Moreira de Mello <mme...@redhat.com>
Date: Mon, 25 Jul 2011 17:19:34 -0300
Subject: [PATCH] RHBZ#725555 - fix typo for test in c.size() and LOG.error statement

---
 .../rhn/common/hibernate/HibernateFactory.java     |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/java/code/src/com/redhat/rhn/common/hibernate/HibernateFactory.java b/java/code/src/com/redhat/rhn/common/hibernate/HibernateFactory.java
index addb07d..c1fed0e 100644
--- a/java/code/src/com/redhat/rhn/common/hibernate/HibernateFactory.java
+++ b/java/code/src/com/redhat/rhn/common/hibernate/HibernateFactory.java
@@ -132,8 +132,8 @@ public abstract class HibernateFactory {
             Map.Entry entry = (Map.Entry) itr.next();
             if (entry.getValue() instanceof Collection) {
                 Collection c = (Collection) entry.getValue();
-                if (c.size() > 100) {
-                    LOG.error("Query exectued with Collection larger than 1000");
+                if (c.size() > 1000) {
+                    LOG.error("Query executed with Collection larger than 1000");
                 }
                 query.setParameterList((String) entry.getKey(), c);
             }
-- 
1.7.6

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to