On 08/22/2011 08:32 AM, Miroslav Suchý wrote:
In:
https://bugzilla.redhat.com/show_bug.cgi?id=705363
Files layout and permissions are Ok, except the issue with
/usr/share/perl5/vendor_perl/PXT/Config.pm:
Notice: perl(PXT::Config) (and /usr/share/perl5/vendor_perl/PXT/Config.pm)
is provided by two packages: spacewalk-base-minimal and spacewalk-pxt.
Is it intentional?
Yes, it is intentional. PXT is quite standalone (but still part of Spacewalk
and primary developed for spacewalk) so it is included directly in that
sub-package and we do not want to force potential user to install
spacewalk-base.
On the other hand we need PXT/Config.pm on Spacewalk proxy and to read
monitoring configuration files, but we do not need there whole PXT. Therefore
it is packaged in -minimal sub-package together with additional essential
files.
Fedora packaging guidelines forbids sharing files between packages
<https://fedoraproject.org/wiki/Packaging/Guidelines#Duplicate_Files>.
FIX: I recommend to split the /usr/share/perl5/vendor_perl/PXT/Config.pm file
into new sub-package and make this sub-package required by
spacewalk-base-minimal and spacewalk-pxt. Otherwise make the two packages
mutually exclusive, or ask Fedora Packaging Committee for exception.
I plan to leave PXT::Config only in spacewalk-base-minimal. And
spacewalk-pxt will require spacewalk-base-minimal.
Does anyone have objection? If there will be no objection till tomorrow,
I will do the split, so I can continue with the review.
None from me.
Ack - http://jbowes.fedorapeople.org/albatross.jpg
Cliff
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
