On Wed, Jul 27, 2011 at 03:47:39PM +0200, Ionuț Arțăriși wrote: > > > >Adding a char to varchar2 definitions would then be step to, and piece > >of cake. > > Hm... writing another tool to do what chameleon currently does seems > like a massive undertaking.
Kudos to Michal Mráka who did just that. The Spacewalk master/nightly build process is now chameleon-free, so if you like, we can move forward with adding the CHAR declaration to the schema definition -- I'll be happy to review a patch. In the patch, you'll also need to amend spacewalk-oracle2postgresql to remove the CHAR from the declaration as PostgreSQL does not support it, and add schema upgrade scripts to modify existing installation. Well, before working on the patch, we should probably decide if the changes should only touch columns where you've already hit the problem, or if you want to change all VARCHAR2 columns in the database. We have multiple columns like LABEL where we only allow limited subset of US-ASCII (typically a-zA-Z0-9_ or something similar), so there it might actually be usefull to keep it BYTE (and explicitly declare it as BYTE) and perhaps also add a CHECK constraint which will enforce this limited subset on the column. -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
