On Thu, Oct 06, 2011 at 05:48:43PM +0200, Tomas Lestach wrote: > Hey Marcelo, > > it's definitely not a good idea to create an object in the getter > method. Especially, if Dmi class is mapped on the appropriate table > using hibernate. > I'd better not return any bios values via xmlrpc at all, when the > whole object is null. A good place for the change is the Serializer.
On Wed, Oct 05, 2011 at 05:04:28PM -0300, Marcelo Moreira de Mello wrote: > Hello, > > After reviewing the patch follow attach a better looking patch for > this bug. Doing our tests, this patch does not include a regression for > bug 452956. > > I created a test package and the API worked as expected. > > Best, > mmello In the end, if fixed both 741476 and 743407 with commit 6742bdedf6669d146316da043048ab16f0862ca9. -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
