On Fri, Nov 11, 2011 at 03:01:35PM -0200, Marcelo Moreira de Mello wrote:
> 
>   Hello team,
> 
>     I'm not very knowledgeable on trigger writing, but follow attached a
> patch which fixes the trigger rhn_channel_mod_trig updating the field
> last_modified only when some new package or change are made into channel.
> 
>     Please, check the complete error description  and tests at BZ#753021.

[...]

> diff --git a/schema/spacewalk/oracle/triggers/rhnChannel.sql 
> b/schema/spacewalk/oracle/triggers/rhnChannel.sql
> index 3a357fa..58ef396 100644
> --- a/schema/spacewalk/oracle/triggers/rhnChannel.sql
> +++ b/schema/spacewalk/oracle/triggers/rhnChannel.sql
> @@ -21,7 +21,9 @@ rhn_channel_mod_trig
>  before insert or update on rhnChannel
>  for each row
>  begin
> -     :new.last_modified := sysdate;
> +    if inserting then
> +         :new.last_modified := sysdate;
> +    end if;

Comment in bugzilla -- I nack this patch.

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to