Johannes Renner wrote:
% Hello,
% 
% It looks like that the following query is not actually doing what it should 
do:
% 
% config_queries.xml: "ssm_channels_for_subscribe_choose"
% 
% How to see that: Put two systems in the SSM where only one of those is 
subscribed
% to a certain config channel. This config channel should appear in the SSM as 
an
% option to subscribe to, because not ALL of the systems in SSM are already 
subscribed.
% What happens is, that as soon as one of the systems in SSM is subscribed to a 
certain
% channel, this channel does not appear as an available config channel in SSM 
anymore.
% 
% I found that the attached patch fixes the issue: While replacing "=" with 
"is" is
% obviously correct, I also found, that as soon as SCC.server_id is null (in 
the last
% subquery) the SCC.config_channel_id is also null. Therefore the proposed fix.
% Further, since the next query in that file is just the negation of this one, 
it would
% probably also need a fix.

Hi Johannes,

although Tomas commited your patch neither original version nor yours
are correct.

a) Select from rhnSet was not restricted to user so it might interfere
with other users SSM servers.

b) Two servers in SSM and three channels:
     server1 subscribed to config1 and config2
     server2 is subscribed only to config1
     (no server subscribed to config3)
query returns only config3 while it should have return config2, config3. 

So I went ahead and rewrote queries completely, please check whether
they work for you. (Commits a0ac26914ef0c80202dc0d707966ec34f523053e and
d50e60bc201b11c7b23c7f7eb06f6a58ee593fb0)

Regards,

--
Michael Mráka
Satellite Engineering, Red Hat

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to