I committed some patches for Cobbler 2.2 support tonight. It'd be great if a
few others could test to ensure I didn't break anything before 1.6 is released.
I tested the following scenarios:
- fresh Cobbler 2.0 install
- fresh Cobbler 2.2 install
- 2.0 to 2.2 upgrade
And these operations:
- create new kickstart
- update existing kickstart
- create cobbler record for a system
/aron
________________________________________
From: spacewalk-devel-boun...@redhat.com [spacewalk-devel-boun...@redhat.com]
on behalf of spacewalk-devel-requ...@redhat.com
[spacewalk-devel-requ...@redhat.com]
Sent: Thursday, December 01, 2011 12:00 PM
To: spacewalk-devel@redhat.com
Subject: Spacewalk-devel Digest, Vol 43, Issue 1
Send Spacewalk-devel mailing list submissions to
spacewalk-devel@redhat.com
To subscribe or unsubscribe via the World Wide Web, visit
https://www.redhat.com/mailman/listinfo/spacewalk-devel
or, via email, send a message with subject or body 'help' to
spacewalk-devel-requ...@redhat.com
You can reach the person managing the list at
spacewalk-devel-ow...@redhat.com
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Spacewalk-devel digest..."
Today's Topics:
1. Re: client/rhel (Miroslav Suchy)
2. Cobbler 2.2 support in 1.6 (Parsons, Aron)
3. Re: Cobbler 2.2 support in 1.6 (Miroslav Suchy)
4. Re: client/rhel (Jan Pazdziora)
5. [PATCH] fix display of static snippets (Uwe Gansert)
6. Re: [PATCH] fix display of static snippets (Jan Pazdziora)
7. Re: [PATCH] fix display of static snippets (Uwe Gansert)
8. Re: [PATCH] fix display of static snippets (Jan Pazdziora)
9. Re: [PATCH] fix display of static snippets (Uwe Gansert)
----------------------------------------------------------------------
Message: 1
Date: Wed, 30 Nov 2011 18:42:54 +0100
From: Miroslav Suchy <msu...@redhat.com>
To: spacewalk-devel@redhat.com
Subject: Re: [Spacewalk-devel] client/rhel
Message-ID: <4ed66b1e.7080...@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Dne 30.11.2011 17:40, Jan Pazdziora napsal(a):
> I don't think you want to just blindly set what getfqdn returns. In
> most cases, IPv4 addresses will have better DNS records than IPv6 but
That is just assumption. In most cases correct. But all this code is
just wild heuristics trying to do less evil.
I can change the order of
for family in (AF_INET, AF_INET6):
in findHostByRoute() to:
for family in (AF_INET6, AF_INET):
I have to admit this will get better data more often.
> you will end up with stuff like
>
> # python -c 'from socket import *; print
> getfqdn("2620:52:0:2223:20c:29ff:fe0e:d05b");'
> 2620:52:0:2223:20c:29ff:fe0e:d05b
>
> in the hostname. You should really check (and test) various scenarios,
> not overwrite the hostname if it already is set from the IPv4 pass,
> and not set it if you get IP address back.
How should I decide which hostname is correct?
And what should I do with machine with IPv4 address 123.45.56.67 which
resolves to machine1.broken.dns and IPv6 address
2620:52:0:2223:20c:29ff:fe0e:d05b which resolves machine2.broken.dns?
If you are unable to resolve the hostname using gethostbyaddr()
(getfqdn() is essentially wrapper around this one function), then you do
not deserve sane data. If user has broken networking, he should fix it
in first place.
Hmm what I can do is:
hostname_tmp = socket.getfqdn(intf_tmp)
if hostname_tmp != intf_tmp:
hostname = hostname_tmp
But you can admit, that user can be so ugly, that machine with hostname
123.45.56.67 will have IPv4 address 123.45.56.67.
I do not think we can catch all possibilities here.
Mirek
Mirek
------------------------------
Message: 2
Date: Wed, 30 Nov 2011 18:19:06 +0000
From: "Parsons, Aron" <parso...@bit-sys.com>
To: "'spacewalk-devel@redhat.com'" <spacewalk-devel@redhat.com>
Subject: [Spacewalk-devel] Cobbler 2.2 support in 1.6
Message-ID:
<38BF0DD94618A6449F9DC97ECCB360A90DB9B923@suhn-mbx2.SIX3.local>
Content-Type: text/plain; charset="us-ascii"
How do we want to handle Cobbler 2.2 support in the upcoming release? 2.2 has
some nice features and I think it'd be good to support it. Do we want to drop
2.0 support or try to work some logic in to detect the Cobbler version? I'm
not sure if we'd want to bring that into places like KickstartFormatter.java.
The items that would need changed in Spacewalk based on a quick look:
- kickstart_{start,done} macros to snippets in
com.redhat.rhn.manager.kickstart.KickstartFormatter
- 'subnet' field changed to 'netmask' in org.cobbler.Network
Am I missing any other changes? Is anyone else already working on this?
/aron
------------------------------
Message: 3
Date: Thu, 01 Dec 2011 10:05:57 +0100
From: Miroslav Suchy <msu...@redhat.com>
To: spacewalk-devel@redhat.com
Subject: Re: [Spacewalk-devel] Cobbler 2.2 support in 1.6
Message-ID: <4ed74375.30...@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Dne 30.11.2011 19:19, Parsons, Aron napsal(a):
> Am I missing any other changes? Is anyone else already working on this?
Nope.
We are aware of drastic changes in 2.2, but no one had time to check
cobbler 2.2. It is presented only in "testing" so it should not break
your Spacewalk right now.
If you are willing to investigate it and make it work, I would be happy.
Mirek
------------------------------
Message: 4
Date: Thu, 1 Dec 2011 11:53:50 +0100
From: Jan Pazdziora <jpazdzi...@redhat.com>
To: spacewalk-devel@redhat.com
Subject: Re: [Spacewalk-devel] client/rhel
Message-ID: <20111201105350.gb3...@redhat.com>
Content-Type: text/plain; charset=us-ascii
On Wed, Nov 30, 2011 at 06:42:54PM +0100, Miroslav Suchy wrote:
> >
> >in the hostname. You should really check (and test) various scenarios,
> >not overwrite the hostname if it already is set from the IPv4 pass,
> >and not set it if you get IP address back.
>
> How should I decide which hostname is correct?
The current behaviour is to take the IPv4-related hostname. You should
not change the behaviour too much.
> And what should I do with machine with IPv4 address 123.45.56.67
> which resolves to machine1.broken.dns and IPv6 address
> 2620:52:0:2223:20c:29ff:fe0e:d05b which resolves
> machine2.broken.dns?
Use machine1.broken.dns because that's what the code did so far
anyway.
> If you are unable to resolve the hostname using gethostbyaddr()
> (getfqdn() is essentially wrapper around this one function), then
> you do not deserve sane data. If user has broken networking, he
> should fix it in first place.
Why should a person be forced to have a valid IPv6 DNS?
> Hmm what I can do is:
> hostname_tmp = socket.getfqdn(intf_tmp)
> if hostname_tmp != intf_tmp:
> hostname = hostname_tmp
>
> But you can admit, that user can be so ugly, that machine with
> hostname 123.45.56.67 will have IPv4 address 123.45.56.67.
>
> I do not think we can catch all possibilities here.
We should not regress.
--
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat
------------------------------
Message: 5
Date: Thu, 01 Dec 2011 13:44:25 +0100
From: Uwe Gansert <u...@suse.de>
To: spacewalk-devel@redhat.com
Subject: [Spacewalk-devel] [PATCH] fix display of static snippets
Message-ID: <4ed776a9.2050...@suse.de>
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Hi,
the read only snippets in the web ui need HTML/XML escaping.
Especially AutoYaST XML snippets tend to be displayed wrong in the UI
without escaping
Patch attached
--
ciao, Uwe Gansert
SUSE LINUX Products GmbH, HRB 16746 (AG N?rnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer
Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_display_of_snippets.diff
Type: text/x-patch
Size: 1106 bytes
Desc: not available
URL:
<https://www.redhat.com/archives/spacewalk-devel/attachments/20111201/8795546b/attachment.bin>
------------------------------
Message: 6
Date: Thu, 1 Dec 2011 13:54:31 +0100
From: Jan Pazdziora <jpazdzi...@redhat.com>
To: spacewalk-devel@redhat.com
Subject: Re: [Spacewalk-devel] [PATCH] fix display of static snippets
Message-ID: <20111201125430.ga8...@redhat.com>
Content-Type: text/plain; charset=us-ascii
On Thu, Dec 01, 2011 at 01:44:25PM +0100, Uwe Gansert wrote:
>
> the read only snippets in the web ui need HTML/XML escaping.
> Especially AutoYaST XML snippets tend to be displayed wrong in the
> UI without escaping
Shouldn't we rather do this in the .jsp?
--
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat
------------------------------
Message: 7
Date: Thu, 01 Dec 2011 16:50:40 +0100
From: Uwe Gansert <u...@suse.de>
To: spacewalk-devel@redhat.com
Subject: Re: [Spacewalk-devel] [PATCH] fix display of static snippets
Message-ID: <4ed7a250.1070...@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
On 01.12.2011 13:54, Jan Pazdziora wrote:
> On Thu, Dec 01, 2011 at 01:44:25PM +0100, Uwe Gansert wrote:
>>
>> the read only snippets in the web ui need HTML/XML escaping.
>> Especially AutoYaST XML snippets tend to be displayed wrong in the
>> UI without escaping
>
> Shouldn't we rather do this in the .jsp?
>
you mean
<c:out value="${data}" escapeXml="true"/>
in the jsp?
That should work too I guess.
I just had the impression all "work" is done in the java files and so I
did it directly there.
jsp is fine with me
--
ciao, Uwe Gansert
SUSE LINUX Products GmbH, HRB 16746 (AG N?rnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer
Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net
------------------------------
Message: 8
Date: Thu, 1 Dec 2011 17:08:45 +0100
From: Jan Pazdziora <jpazdzi...@redhat.com>
To: spacewalk-devel@redhat.com
Subject: Re: [Spacewalk-devel] [PATCH] fix display of static snippets
Message-ID: <20111201160845.gb8...@redhat.com>
Content-Type: text/plain; charset=us-ascii
On Thu, Dec 01, 2011 at 04:50:40PM +0100, Uwe Gansert wrote:
> On 01.12.2011 13:54, Jan Pazdziora wrote:
> >On Thu, Dec 01, 2011 at 01:44:25PM +0100, Uwe Gansert wrote:
> >>
> >>the read only snippets in the web ui need HTML/XML escaping.
> >>Especially AutoYaST XML snippets tend to be displayed wrong in the
> >>UI without escaping
> >
> >Shouldn't we rather do this in the .jsp?
> >
>
> you mean
> <c:out value="${data}" escapeXml="true"/>
> in the jsp?
Nod.
--
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat
------------------------------
Message: 9
Date: Thu, 01 Dec 2011 17:30:18 +0100
From: Uwe Gansert <u...@suse.de>
To: spacewalk-devel@redhat.com
Subject: Re: [Spacewalk-devel] [PATCH] fix display of static snippets
Message-ID: <4ed7ab9a.9030...@suse.de>
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
On 01.12.2011 17:08, Jan Pazdziora wrote:
>>>> the read only snippets in the web ui need HTML/XML escaping.
>>>> Especially AutoYaST XML snippets tend to be displayed wrong in the
>>>> UI without escaping
>>>
>>> Shouldn't we rather do this in the .jsp?
>>>
>>
>> you mean
>> <c:out value="${data}" escapeXml="true"/>
>> in the jsp?
patch attached
--
ciao, Uwe Gansert
SUSE LINUX Products GmbH, HRB 16746 (AG N?rnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer
Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 597 bytes
Desc: not available
URL:
<https://www.redhat.com/archives/spacewalk-devel/attachments/20111201/4edfe3a5/attachment.bin>
------------------------------
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
End of Spacewalk-devel Digest, Vol 43, Issue 1
**********************************************
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
