On Friday 30 of March 2012 10:44:19 Johannes Renner wrote:
> Hey,
> 
> You are using checkstyle 4.1 it seems, while we use version 4.3.
> Our version seems to need the lib directory jars to be contained
> in the classpath for finding exception classes the are referenced
> by @throws clauses. Otherwise we get a lot of these errors:
> 
> ./code/src/com/redhat/rhn/common/hibernate/HibernateFactory.java:0: Got an
> exception - java.lang.RuntimeException: Unable to get class information for
> @throws tag 'HibernateException'.

Since the change does not break our checkstyle, and fixes yous :-), applying 
as: 894008bb9d1dd94b8c3677bfe01c57812c75e881

> 
> Also 4.3 doesn't like the @{inherit-doc} for methods that are not
> actually overrides, like the constructor in ScapActionDetails.java:
> 
> ./code/src/com/redhat/rhn/domain/action/scap/ScapActionDetails.java:33:5:
> Invalid use of the {@inheritDoc} tag.

Right, you're correct. Applied as: 1608dcf63390c62b2acf62476ba8040a7b9d799a

> 
> Just in case you are planning to upgrade or want to fix anyways.
> 
> Regards,
> Johannes

Thank you, Johannes!

Regards,
-- 
Tomas Lestach
RHN Satellite Engineering

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to