On 2.4.2012 14:47, Johannes Renner wrote:
Hey,
After running our testsuite against a recent codebase, we saw (from
catalina.out)
that the following removed strings seem to be still in use:
configchannelfilter.name
configfilefilter.path
config_subscribed_systems.unsubscribeSystems.success
config_target_systems.subscribeSystems.success
help.jsp.quickstart.detailed
help.jsp.quickstart.title
preferences.critical-probes.description
preferences.critical-probes.name
preferences.critical-systems.description
preferences.critical-systems.name
preferences.inactive-systems.description
preferences.inactive-systems.name
sdc.config.differing.files_1
sdc.config.diff.files_1_dirs_0_symlinks_0
userlist.jsp.disabled
userlist.jsp.enabled
It looks like these are all from the .../jsp/StringResource_en_US.xml file.
So, how to cleanly revert only parts of such a big commit? I saw you did that
already for e.g. doing 8899861.
Yes, as I previously said: I removed each string in separate commit, but
teammates preferred in this special case one big commit instead of 900
smaller ones. So I squash it before pulling, but I have them still
separate in my private branch.
So for me it is just simple git revert.
I reverted all mentioned ones but these two:
> help.jsp.quickstart.detailed
> help.jsp.quickstart.title
I did not removed it and I do see it in our code as well - even "git
grep quickstart" in /java/ is silent.
Is it possible it is something only in your private branch?
Mirek
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
