Hello Johannes,

On Friday 03 of August 2012 12:44:11 Johannes Renner wrote:
> Hi,
> 
> We found out that commit 16f30f97d657ab7019489dfac5a11f67afc2143e apparently
> broke the Errata page for custom channels:
> 
> https://<hostname>/rhn/channels/manage/errata/ListRemove.do?cid=XXX
> 
> Sorting (by clicking on the columns) as well as filtering the list is broken
> and it seems as if the query is not actually elaborated.

You're right here. My fault.
We need to fetch the attributes according to those we want to sort in the 
original query - even if they get elaborated later on.

> 
> So I am coming up with two patch proposals, since I am not really sure about
> how we are intended to solve the problem:
> 
> - The first patch fixes it by calling elaborate() manually once

I wouldn't call the elaborate method manually. Since the mechanism has worked 
till now, I'd rather revert my original commit.

spacewalk.git: 43fbb66782bebe62e5aa323bc5edf70276d2609b

> - The second patch is a more generic fix and calls elaborate() in
>   BaseManager.java even if PageControl is null

What is the bug you try to fix with the 2nd patch? Could you describe the 
misbehavior on a concrete page?

> 
> What do you think, can you actually reproduce the bug?
> Why would we want to return an unelaborated list in case PageControl is
> null?
> 
> Regards,
> Johannes

Regards,
-- 
Tomas Lestach
RHN Satellite Engineering

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to