[Spacewalk-devel] [PATCH] BZ#874278 - API method errata.findByCve() returns java exception java.util.ConcurrentModificationException() when listing erratas

[Marcelo Moreira de Mello]

Howdy Spacewalk folks,

   Here follow a patch which addressed the issue reported on BZ#874278.

   Further details on the bz.

  Thank you.

Best Regards,
mmello

-- 
Marcelo Moreira de Mello
RHCA RHCSS RHCVA
Senior Software Maintenance Engineer/SEG        

gpg id: 2048R/FDB110E5
gpg fingerprint: 3BE7 EF71 4DD7 6812 D309  8F18 BD42 D095 FDB1 10E5


From: Marcelo Moreira de Mello <mme...@redhat.com>
Date: Wed, 7 Nov 2012 21:47:20 -0200
Subject: [PATCH] fixed errata.findByCve() method for seek big lists

Caused by: java.util.ConcurrentModificationException     
  at java.util.LinkedList$LinkIterator.next(LinkedList.java:119)
  at com.redhat.rhn.frontend.xmlrpc.errata.ErrataHandler.findByCve(ErrataHandler.java:1427)

---
 .../src/com/redhat/rhn/frontend/xmlrpc/errata/ErrataHandler.java     | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/java/code/src/com/redhat/rhn/frontend/xmlrpc/errata/ErrataHandler.java b/java/code/src/com/redhat/rhn/frontend/xmlrpc/errata/ErrataHandler.java
index f86058c..2a7baaa 100644
--- a/java/code/src/com/redhat/rhn/frontend/xmlrpc/errata/ErrataHandler.java
+++ b/java/code/src/com/redhat/rhn/frontend/xmlrpc/errata/ErrataHandler.java
@@ -1461,11 +1461,12 @@ public class ErrataHandler extends BaseHandler {
         User loggedInUser = getLoggedInUser(sessionKey);
 
         List<Errata> erratas = ErrataManager.lookupByCVE(cveName);
-        for (Errata errata : erratas) {
+        for (Iterator iter = erratas.iterator(); iter.hasNext();) {
+            Errata errata = (Errata) iter.next();
             // Remove errata that do not apply to the user's org
             if (errata.getOrg() != null &&
                     !errata.getOrg().equals(loggedInUser.getOrg())) {
-                erratas.remove(errata);
+                iter.remove();
             }
         }
         return erratas;
-- 
1.8.0


_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel