On 11/08/2012 10:34 AM, Parsons, Aron wrote:
Can anyone explain the rationale behind commit 
7a18b250b07ff4ed0c34fa48e69029c114ec3ab1?  I do not have access to the BZ that 
it references.

I don't see the security implications of generating a diff for a 
non-world-readable file.  Unauthorized users can't read the file on the system

This did not used to be true. We were generating diffs of every file and placing them in a readable-by-anyone log file. In bug 824707 we fix this problem by

1) Not diffing files that are not readable by all in 7a18b250b07ff4ed0c34fa48e69029c114ec3ab1

and then we also

2) Made the log file only readable by root in 0cb9f801bfc073cd68111868014219407b73f9f9

Both are probably not necessary, but the feeling at the time was "better safe than sorry."

-Stephen

  and you need to have access to the system in Spacewalk to view the output.  
Is there another scenario that makes returning the diff insecure?

/aron

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to