On Tuesday 20 of November 2012 13:53:14 Johannes Renner wrote:
> On 11/15/2012 03:57 PM, Johannes Renner wrote:
> > Hey again,
> > 
> > We found some errors with the prefix field of a user's properties. First,
> > when creating a new user with the UI, it is not possible to leave the
> > prefix empty, it complains about a non-valid value (even though an
> > 'empty' value is actually contained in the prefixes list). Further, when
> > editing a user's details it is not possible to empty the prefix. This is
> > especially annoying if you used e.g. spacecmd to create a user without a
> > prefix. It is then later on not even possible to edit and save such a
> > user without changing the prefix. I reproduced these issues reliably on
> > Oracle as well as on PG.
> > 
> > The attached patch fixes the problem by setting the apparently correct
> > empty value of " ", just in case it is empty (== ""). The select in the
> > form might even return it correctly as " ", but looks like it is maybe
> > trimmed away somewhere.. This works for me now, but I tested the fix on
> > PG only.
> > 
> > Thanks,
> > Johannes
> 
> Oh sorry, I just found out that my first patch had a subtle bug.. creating
> users with an empty prefix was still failing, even with the patch deployed.
> 
> Attached is now a fixed version that should really make it work.

Committed as: 12ee8d60a358cd3f435fdb88c61227e3d61f6b6e

Thank you!
Regards,
-- 
Tomas Lestach
RHN Satellite Engineering

> 
> Regards,
> Johannes

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to