On Tuesday 08 of January 2013 20:04:01 Paresh Mutha wrote:
> Hello,
>
> We had an issue on snapshot tags reported on satellite (bz#893068).
> While troubleshooting I see that it is likely a bug due to a typo in
> Sever.pm. Details below :
>
> /etc/rhn/rhn.conf has :
> # system snapshots enabled
> enable_snapshots = 1
>
> whereas under /usr/share/perl5/vendor_perl/RHN/DB/Server.pm it checks
> for enable_snapshot config value which doesn't exist (missing trailing s
> in config variable):
>
> sub snapshot_server {
> my $class = shift;
> my %params = validate(@_, {server_id => 1, reason => 1, transaction
> => 0});
>
> if (!PXT::Config->get('enable_snapshot')) {
> return;
> }
>
>
> While creating the snapshot it checks the config value of
> enable_snapshot which does not exists in default config. Thus inspite of
> having enable_snapshots=1 in rhn.conf, still it returns without creating
> a snapshot.
>
> Attached the proposed patch to correct the behavior. Appreciate your
> feedback/thoughts on it.
>
> Regards,
> Paresh
Paresh,
your patch looks good.
I committed it as:
http://git.fedorahosted.org/cgit/spacewalk.git/commit/?id=00ddca18317315e105d69c304bf3e5a1f047fa48
Thank you!
--
Tomas Lestach
RHN Satellite Engineering
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
