Hi Duncan, thanks for your patches. I committed following: eb7beb3277fb8db48376e44c058bde8ad5d1be45 1db45d611fbc307b4eac1fa35d25ed3b30dc6fac 668f52d928590b4bc7e2d3c955f2b6a59e5d3fb8
I didn't commit following ones: *TaskoRun Log tail: Handle the case where more bytes are requested than the current size of the log. - I rather return the whole log file in case more bytes are requested, so I committed this code: 6012adfcc5d4ae182c164a3e64e442255f44751c - anyway thank you for pointing on that situation * both ChannelStatus commits - generally I like the idea, implementation, spinning icons, but I mean they aren't complete - I didn't find a way the 'Repo Cache Status' would say 'Completed' or 'Failed'. - are you sure you sent everything? - even if my repo was regenerated, I saw just '(none)' on the page - please check and I'd be happy to commit your patches Btw. would you run checkstyle before sending patches, please? Regards, Tomas -- Tomas Lestach RHN Satellite Engineering On Monday 11 of February 2013 10:33:24 Duncan Mac-Vicar P. wrote: > The following patches improve the status of a channel by taking into > account both download/mirror _and_ repodata generation. > > The download/sync status was a bit tricky to get, as the taskomatic > table is made polymorphic by serializing java objects which in turn > contain the channel_id, so you can't just SQL it. > > Some bugs are fixed in order to get everything working, specially > failing when exit code of external programs is not successful, and > getting the tail log for logs smaller than the requested tail. > > The status is exposed as a ChannelStatus class. > > This could be displayed as icons (spinning wheel, exclamation) in the > overview lists, but as I don't have a concept for the UI I kept it in > the channel details page, as the "half" status was already there. > > The patches are intended for review, but are not yet rebased against master. > > commit c523b18667ace8acd5dd835378e87d0be45f9473 > Author: Duncan Mac-Vicar P <dmacvi...@suse.de> > Date: Thu Jan 31 17:45:25 2013 +0100 > > Improve the Channel Details page by using the status generated > by ChannelStatus, which includes also repo-sync information. > > commit 080232549c07e6c38caaebbaa640530efebcd614 > Author: Duncan Mac-Vicar P <dmacvi...@suse.de> > Date: Thu Jan 31 11:31:36 2013 +0100 > > Introduce ChannelStatus as an agregate way to query both the repo-sync > and repodata generation status of a channel. > > The class also carries a log to transport debug information to the > admin. In the future, more data or sub-statuses could be added to > this class. > > The ChannelStatus is exposed in ChannelManager::statusForLabel(label) > and ChannelManager::isChannelLabelInProgress(label) gets deprecated > and reimplemented using ChannelManager::statusForLabel(label). > > The Task queries get a new query to ask for candidate repodata > generation workers and the active ones gets renamed to keep the > names meanful and consistent. > > commit caec97d8d2b88f008cb0e70391cb572207f6b1da > Author: Duncan Mac-Vicar P <dmacvi...@suse.de> > Date: Wed Jan 30 18:37:52 2013 +0100 > > RhnJavaJob: Do not ignore the exit code for external programs. > > commit 630870f813d2deaf2b95d8a133fdfd78e110c05a > Author: Duncan Mac-Vicar P <dmacvi...@suse.de> > Date: Wed Jan 30 18:31:01 2013 +0100 > > TaskoRun Log tail: Handle the case where more bytes are requested > than the current size of the log. > > commit 6f445ce3e1f85fecbe4010f3cfce1a5724dab286 > Author: Duncan Mac-Vicar P <dmacvi...@suse.de> > Date: Wed Jan 30 18:30:09 2013 +0100 > > Do not silence catched exceptions. Debugging can be hard. > > commit ce3c088b4890e40273aa846bad0501bd62367080 > Author: Duncan Mac-Vicar P <dmacvi...@suse.de> > Date: Wed Jan 30 18:29:25 2013 +0100 > > FileNotFoundException inherits IOException so no need for a separate > catch block if the catch code is the same (none). _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
