On Thu, Apr 04, 2013 at 03:37:07PM +0200, Johannes Renner wrote:
> On 03/22/2013 02:55 PM, Michael Calmer wrote:
> > Hi,
> >
> > please do not apply these patches. I found out, that it is not correct.
> > It removes the channels at more places than needed.
>
> I guess the initial patch would be fine, as long as we add some additional
> small fixes on top. Here is another single patch containing everything.
>
> Basically what we are doing is to distinguish between "kickstartable" and
> "autoinstallable" channels. It would be really helpful though to get some
> feedback from you about using the anaconda package as a filter criteria.
Can you elaborate on the purpose of this change in general? The current
code uses the
Channel.kickstartableChannels
query everywhere (via getKickstartableChannels). The patch seems to
change the semantics for all getKickstartableChannels(org)
invocations. What is the purpose? Why should all the other invocations
start to care about anaconda?
Also, I'm not sure about the use of
ChannelManager.listLatestPackagesEqual here -- we don't care about
the latest at all, do we? The thing is happy about any package it
finds so the best way is to just check for existence, without any
newest computation needed.
--
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
