----- Original Message ----- > Hi, > > I noticed that buildPageLink() uses a HashMap to keep track of query > string parameters. While this is perfectly okay from a web application > point of view, it makes testing a little more difficult and in > particular, RequestContextTest could break because it implicitly relies > on key ordering. > > In the attached patch I propose using a TreeMap instead, which produces > a reliable ordering.
commit da246692162aca79b92942582a18205960db1b4a I made a small change - using a TreeMap doesn't require changing the type of the variable to SortedMap, the rest of the code is still happy using Map methods. Thanks for the contribution! G > > Regards, > -- > Silvio Moioli > SUSE LINUX Products GmbH > Maxfeldstraße 5, 90409 Nürnberg Germany > > > > > _______________________________________________ > Spacewalk-devel mailing list > Spacewalk-devel@redhat.com > https://www.redhat.com/mailman/listinfo/spacewalk-devel _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
