----- Original Message -----
> Hi,
> 
> If I understand  code correctly MasterHandlerTest is about testing that
> some methods can or cannot be called by administrators and regular
> users. IssMaster objects are created ad-hoc for testing, and one of them
> is "flagged" and "unflagged" as default during the tests themselves. The
> only problem is the very first call to getDefaultMaster(): since none of
> the test IssMaster objects has been flagged as default yet, the call may
> or may not throw exceptions depending on the previous state.
> 
> The attached patch simply ignores such exception for the very first call.

commit abe60ece5e469c3a5508f12f9f55ef00d472e561

Just fyi - the goal of the initial getDefaultMaster() call, was to be able to 
put it back post-test, so that we didn't change the state of the spacewalk 
instance we're running against (which was, when this test was written, my 
dev-instance :) )

Tempted to just yank the get/reset code entirely - but not this commit.

Thanks for your contribution!

G

> 
> Regards,
> --
> Silvio Moioli
> SUSE LINUX Products GmbH
> Maxfeldstraße 5, 90409 Nürnberg Germany
> 
> 
> 
> _______________________________________________
> Spacewalk-devel mailing list
> Spacewalk-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-devel

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to