Hi,

when we build spacewalk-java we got ugly warnings like this one:

[   84s]     [javac] /usr/src/packages/BUILD/spacewalk-java-
git-5625.44000ca/build/jsp-
temp/org/apache/jsp/WEB_002dINF/pages/admin/errata/confirm_jsp.java:498: 
warning: unmappable character for encoding ASCII
[   84s]     [javac]     
_jspx_th_rhn_005ftoolbar_005f2.setIcon("????spacewalk-icon-enhancement");

Seems, that we introduced a UTF-8 space there.

The attached patch replace them with a normal space character.

-- 
Regards

        Michael Calmer

--------------------------------------------------------------------------
Michael Calmer
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
T: +49 (0) 911 74053 0
F: +49 (0) 911 74053575  - e-mail: michael.cal...@suse.com
--------------------------------------------------------------------------
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
HRB 16746 (AG Nürnberg)
>From 0ec921f199b133fd47e8efa1e90e691ae6977bdb Mon Sep 17 00:00:00 2001
From: Michael Calmer <m...@suse.de>
Date: Wed, 20 Nov 2013 16:08:36 +0100
Subject: [PATCH] replace UTF-8 space character with normal space character

---
 java/code/webapp/WEB-INF/pages/admin/errata/cloneconfirm.jsp          | 2 +-
 java/code/webapp/WEB-INF/pages/channel/erratalist.jsp                 | 2 +-
 java/code/webapp/WEB-INF/pages/channel/manage/addcustomerrata.jsp     | 2 +-
 java/code/webapp/WEB-INF/pages/channel/manage/adderrataredhat.jsp     | 2 +-
 java/code/webapp/WEB-INF/pages/channel/manage/confirmerrata.jsp       | 2 +-
 java/code/webapp/WEB-INF/pages/channel/manage/erratasync.jsp          | 2 +-
 .../webapp/WEB-INF/pages/common/fragments/errata/errata-header.jspf   | 2 +-
 .../webapp/WEB-INF/pages/common/fragments/errata/erratadelete.jspf    | 2 +-
 .../WEB-INF/pages/common/fragments/errata/ownedlistdisplay.jspf       | 2 +-
 .../WEB-INF/pages/common/fragments/errata/relevant-errata-list.jspf   | 2 +-
 .../WEB-INF/pages/common/fragments/yourrhn/mostCriticalSystems.jsp    | 2 +-
 java/code/webapp/WEB-INF/pages/errata/erratasearch.jsp                | 4 ++--
 java/code/webapp/WEB-INF/pages/ssm/packageupgrade.jsp                 | 2 +-
 java/code/webapp/WEB-INF/pages/ssm/systems/ssm-errata.jsp             | 2 +-
 .../code/webapp/WEB-INF/pages/systems/details/packages/upgradable.jsp | 2 +-
 java/code/webapp/WEB-INF/pages/systems/errata.jsp                     | 2 +-
 java/code/webapp/WEB-INF/pages/systems/errataconfirm.jsp              | 2 +-
 17 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/java/code/webapp/WEB-INF/pages/admin/errata/cloneconfirm.jsp b/java/code/webapp/WEB-INF/pages/admin/errata/cloneconfirm.jsp
index a186edb..3c2052a 100644
--- a/java/code/webapp/WEB-INF/pages/admin/errata/cloneconfirm.jsp
+++ b/java/code/webapp/WEB-INF/pages/admin/errata/cloneconfirm.jsp
@@ -23,7 +23,7 @@
             <i class="fa fa-bug"></i>
         </c:if>
         <c:if test="${current.productEnhancement}">
-            <i class="fa  spacewalk-icon-enhancement"></i>
+            <i class="fa  spacewalk-icon-enhancement"></i>
         </c:if>
     </rhn:column>
     <rhn:column header="erratalist.jsp.advisory">
diff --git a/java/code/webapp/WEB-INF/pages/channel/erratalist.jsp b/java/code/webapp/WEB-INF/pages/channel/erratalist.jsp
index f6291af..ea2846d 100644
--- a/java/code/webapp/WEB-INF/pages/channel/erratalist.jsp
+++ b/java/code/webapp/WEB-INF/pages/channel/erratalist.jsp
@@ -35,7 +35,7 @@
 					            <i class="fa fa-bug" title="<bean:message key='erratalist.jsp.bugadvisory' />"></i>
 					        </c:if>
 					        <c:if test="${current.productEnhancement}">
-					            <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory' />"></i>
+					            <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory' />"></i>
 					        </c:if>
 
                 </rl:column>
diff --git a/java/code/webapp/WEB-INF/pages/channel/manage/addcustomerrata.jsp b/java/code/webapp/WEB-INF/pages/channel/manage/addcustomerrata.jsp
index 9d25e72..c94b317 100644
--- a/java/code/webapp/WEB-INF/pages/channel/manage/addcustomerrata.jsp
+++ b/java/code/webapp/WEB-INF/pages/channel/manage/addcustomerrata.jsp
@@ -100,7 +100,7 @@
 							            <i class="fa fa-bug" title="<bean:message key='erratalist.jsp.bugadvisory'/>"></i>
 							        </c:if>
 							        <c:if test="${current.productEnhancement}">
-							            <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory'/>"></i>
+							            <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory'/>"></i>
 							        </c:if>
 				</rl:column>	  		
 		  		
diff --git a/java/code/webapp/WEB-INF/pages/channel/manage/adderrataredhat.jsp b/java/code/webapp/WEB-INF/pages/channel/manage/adderrataredhat.jsp
index 3a36eb3..17b88a8 100644
--- a/java/code/webapp/WEB-INF/pages/channel/manage/adderrataredhat.jsp
+++ b/java/code/webapp/WEB-INF/pages/channel/manage/adderrataredhat.jsp
@@ -122,7 +122,7 @@
 							            <i class="fa fa-bug" title="<bean:message key='erratalist.jsp.bugadvisory'/>"></i>
 							        </c:if>
 							        <c:if test="${current.productEnhancement}">
-							            <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory'/>"></i>
+							            <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory'/>"></i>
 							        </c:if>
 				</rl:column>	  		
 		  		
diff --git a/java/code/webapp/WEB-INF/pages/channel/manage/confirmerrata.jsp b/java/code/webapp/WEB-INF/pages/channel/manage/confirmerrata.jsp
index d44bc0e..d140851 100644
--- a/java/code/webapp/WEB-INF/pages/channel/manage/confirmerrata.jsp
+++ b/java/code/webapp/WEB-INF/pages/channel/manage/confirmerrata.jsp
@@ -30,7 +30,7 @@
 									<td>${bug_count}</td>
 							</tr>
 							<tr>
-									<th><i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory'/>"></i>
+									<th><i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory'/>"></i>
 										Product Enhancement Advisory:
 									</th>
 									<td>${enhance_count}</td>
diff --git a/java/code/webapp/WEB-INF/pages/channel/manage/erratasync.jsp b/java/code/webapp/WEB-INF/pages/channel/manage/erratasync.jsp
index 2e2bf43..c8d2abe 100644
--- a/java/code/webapp/WEB-INF/pages/channel/manage/erratasync.jsp
+++ b/java/code/webapp/WEB-INF/pages/channel/manage/erratasync.jsp
@@ -42,7 +42,7 @@
                            headerclass="thin-column"
                            sortattr="advisoryType">
                         <c:if test="${current.advisoryType == 'Product Enhancement Advisory'}">
-				 <i class="fa  spacewalk-icon-enhancement" title="Product Enhancement Advisory"></i>
+				 <i class="fa  spacewalk-icon-enhancement" title="Product Enhancement Advisory"></i>
                         </c:if>
                        <c:if test="${current.advisoryType == 'Security Advisory'}">
 				 <i class="fa fa-lock" title="Security Advisory"></i>
diff --git a/java/code/webapp/WEB-INF/pages/common/fragments/errata/errata-header.jspf b/java/code/webapp/WEB-INF/pages/common/fragments/errata/errata-header.jspf
index 912e00b..2e129b0 100644
--- a/java/code/webapp/WEB-INF/pages/common/fragments/errata/errata-header.jspf
+++ b/java/code/webapp/WEB-INF/pages/common/fragments/errata/errata-header.jspf
@@ -28,7 +28,7 @@
 	 </rhn:toolbar>
  </c:if>
  <c:if test="${errata.productEnhancement}">
-     <rhn:toolbar base="h1" icon=" spacewalk-icon-enhancement"
+     <rhn:toolbar base="h1" icon=" spacewalk-icon-enhancement"
      						iconAlt="errata-legend.jsp.enhancement"
 						helpUrl="/rhn/help/reference/en-US/s1-sm-errata.jsp">
 	   <c:if test="${empty errata}">
diff --git a/java/code/webapp/WEB-INF/pages/common/fragments/errata/erratadelete.jspf b/java/code/webapp/WEB-INF/pages/common/fragments/errata/erratadelete.jspf
index 0f9248d..76ba418 100644
--- a/java/code/webapp/WEB-INF/pages/common/fragments/errata/erratadelete.jspf
+++ b/java/code/webapp/WEB-INF/pages/common/fragments/errata/erratadelete.jspf
@@ -8,7 +8,7 @@
             <i class="fa fa-bug"></i>
         </c:if>
         <c:if test="${current.productEnhancement}">
-            <i class="fa  spacewalk-icon-enhancement"></i>
+            <i class="fa  spacewalk-icon-enhancement"></i>
         </c:if>
     </rhn:column>
     <rhn:column header="erratalist.jsp.advisory">
diff --git a/java/code/webapp/WEB-INF/pages/common/fragments/errata/ownedlistdisplay.jspf b/java/code/webapp/WEB-INF/pages/common/fragments/errata/ownedlistdisplay.jspf
index 5dccb7a..012eb28 100644
--- a/java/code/webapp/WEB-INF/pages/common/fragments/errata/ownedlistdisplay.jspf
+++ b/java/code/webapp/WEB-INF/pages/common/fragments/errata/ownedlistdisplay.jspf
@@ -18,7 +18,7 @@
                 <i class="fa fa-bug" title="<bean:message key='erratalist.jsp.bugadvisory'/>"></i>
             </c:if>
             <c:if test="${current.productEnhancement}">
-                <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory'/>"></i>
+                <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory'/>"></i>
             </c:if>
         </rl:column>
         <rl:column headerkey="erratalist.jsp.advisory">
diff --git a/java/code/webapp/WEB-INF/pages/common/fragments/errata/relevant-errata-list.jspf b/java/code/webapp/WEB-INF/pages/common/fragments/errata/relevant-errata-list.jspf
index 3d82a6c..81f3f52 100644
--- a/java/code/webapp/WEB-INF/pages/common/fragments/errata/relevant-errata-list.jspf
+++ b/java/code/webapp/WEB-INF/pages/common/fragments/errata/relevant-errata-list.jspf
@@ -14,7 +14,7 @@
                 <i class="fa fa-bug" title="<bean:message key='erratalist.jsp.bugadvisory'/>"></i>
             </c:if>
             <c:if test="${current.productEnhancement}">
-                <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory'/>"></i>
+                <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory'/>"></i>
             </c:if>
         </rl:column>
         <rl:column headerkey="erratalist.jsp.advisory">
diff --git a/java/code/webapp/WEB-INF/pages/common/fragments/yourrhn/mostCriticalSystems.jsp b/java/code/webapp/WEB-INF/pages/common/fragments/yourrhn/mostCriticalSystems.jsp
index 6b34395..293a0c4 100644
--- a/java/code/webapp/WEB-INF/pages/common/fragments/yourrhn/mostCriticalSystems.jsp
+++ b/java/code/webapp/WEB-INF/pages/common/fragments/yourrhn/mostCriticalSystems.jsp
@@ -42,7 +42,7 @@
 
     	<rl:column headerkey="yourrhn.jsp.criticalsystems.enhancementerrata"
     			headerclass="row-2 text-align: center;">
-   			<i class="fa  spacewalk-icon-enhancement" title="<bean:message key='errata-legend.jsp.enhancement'/>"></i>${current.enhancementErrata}		
+   			<i class="fa  spacewalk-icon-enhancement" title="<bean:message key='errata-legend.jsp.enhancement'/>"></i>${current.enhancementErrata}		
     	</rl:column>
 
 	</rl:list>
diff --git a/java/code/webapp/WEB-INF/pages/errata/erratasearch.jsp b/java/code/webapp/WEB-INF/pages/errata/erratasearch.jsp
index 85629db..7a1f9db 100644
--- a/java/code/webapp/WEB-INF/pages/errata/erratasearch.jsp
+++ b/java/code/webapp/WEB-INF/pages/errata/erratasearch.jsp
@@ -88,7 +88,7 @@
                 </div>
                 <div class="checkbox">
                 <html:checkbox property="errata_type_enhancement">
-                    <i class="fa  spacewalk-icon-enhancement"></i>
+                    <i class="fa  spacewalk-icon-enhancement"></i>
                     <bean:message key="erratalist.jsp.productenhancementadvisory"/>
                 </html:checkbox>
                 </div>
@@ -173,7 +173,7 @@
 		  <i class="fa fa-bug"></i>
 		</c:if>
 		<c:if test="${current.productEnhancement}">
-		  <i class="fa  spacewalk-icon-enhancement"></i>
+		  <i class="fa  spacewalk-icon-enhancement"></i>
 		</c:if>
       </rl:column>
 
diff --git a/java/code/webapp/WEB-INF/pages/ssm/packageupgrade.jsp b/java/code/webapp/WEB-INF/pages/ssm/packageupgrade.jsp
index 50b43af..f147469 100644
--- a/java/code/webapp/WEB-INF/pages/ssm/packageupgrade.jsp
+++ b/java/code/webapp/WEB-INF/pages/ssm/packageupgrade.jsp
@@ -59,7 +59,7 @@
                 <i class="fa fa-bug" title="<bean:message key='erratalist.jsp.bugadvisory' />"></i>
               </c:if>
               <c:if test="${current.advisoryType == 'Product Enhancement Advisory'}">
-                <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory' />"></i>
+                <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory' />"></i>
               </c:if>
               <a href="/rhn/errata/details/Details.do?eid=${current.advisoryId}">${current.advisory}</a><br/>
             </c:if>
diff --git a/java/code/webapp/WEB-INF/pages/ssm/systems/ssm-errata.jsp b/java/code/webapp/WEB-INF/pages/ssm/systems/ssm-errata.jsp
index 60938bb..1cfec32 100644
--- a/java/code/webapp/WEB-INF/pages/ssm/systems/ssm-errata.jsp
+++ b/java/code/webapp/WEB-INF/pages/ssm/systems/ssm-errata.jsp
@@ -45,7 +45,7 @@
                         <i class="fa fa-bug"></i>
                     </c:if>
                     <c:if test="${current.productEnhancement}">
-                        <i class="fa  spacewalk-icon-enhancement"></i>
+                        <i class="fa  spacewalk-icon-enhancement"></i>
                     </c:if>
                 </rl:column>
 
diff --git a/java/code/webapp/WEB-INF/pages/systems/details/packages/upgradable.jsp b/java/code/webapp/WEB-INF/pages/systems/details/packages/upgradable.jsp
index 9cce589..3ce0e73 100644
--- a/java/code/webapp/WEB-INF/pages/systems/details/packages/upgradable.jsp
+++ b/java/code/webapp/WEB-INF/pages/systems/details/packages/upgradable.jsp
@@ -59,7 +59,7 @@
             <i class="fa fa-bug" title="<bean:message key='erratalist.jsp.bugadvisory' />"></i>
           </c:if>
           <c:if test="${errata.type == 'Product Enhancement Advisory'}">
-            <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory' />"></i>
+            <i class="fa  spacewalk-icon-enhancement" title="<bean:message key='erratalist.jsp.productenhancementadvisory' />"></i>
           </c:if>
           <a href="/rhn/errata/details/Details.do?eid=${errata.id}">${errata.advisory}</a><br/>
         </c:if>
diff --git a/java/code/webapp/WEB-INF/pages/systems/errata.jsp b/java/code/webapp/WEB-INF/pages/systems/errata.jsp
index e3ad492..7678dbc 100644
--- a/java/code/webapp/WEB-INF/pages/systems/errata.jsp
+++ b/java/code/webapp/WEB-INF/pages/systems/errata.jsp
@@ -88,7 +88,7 @@
 		        <i class="fa fa-bug"></i>
 		      </c:if>
 		      <c:if test="${current.productEnhancement}">
-		        <i class="fa  spacewalk-icon-enhancement"></i>
+		        <i class="fa  spacewalk-icon-enhancement"></i>
 		      </c:if>
 		  </rl:column>
 		
diff --git a/java/code/webapp/WEB-INF/pages/systems/errataconfirm.jsp b/java/code/webapp/WEB-INF/pages/systems/errataconfirm.jsp
index d234ea6..92e2eb4 100644
--- a/java/code/webapp/WEB-INF/pages/systems/errataconfirm.jsp
+++ b/java/code/webapp/WEB-INF/pages/systems/errataconfirm.jsp
@@ -37,7 +37,7 @@
         <i class="fa fa-bug"></i>
       </c:if>
       <c:if test="${current.productEnhancement}">
-        <i class="fa  spacewalk-icon-enhancement"></i>
+        <i class="fa  spacewalk-icon-enhancement"></i>
       </c:if>
     </rl:column>
 
-- 
1.8.1.4

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to