Hello Michele,
as you write in the comment - nobase and ignoremissing are not proper
kickstartoptioncommands, so they do not belong to them.
I am not going to apply the patch.
The proper implementation would be to introduce new API call
* kickstart.profile.software.setSoftwareList with 'ignore missing' and 'don't
install Base' parameters.
Regards,
--
Tomas Lestach
Red Hat Satellite Engineering, Red Hat
----- Original Message -----
> From: "Michele Baldessari" <mich...@acksyn.org>
> To: spacewalk-devel@redhat.com
> Sent: Sunday, December 1, 2013 11:42:06 AM
> Subject: [Spacewalk-devel] [PATCH] Add nobase and ignoremissing options in
> setAdvancedOptions()
>
> It is currently not possible via API to create a kickstart
> profile that sets either '--ignoremissing' or '--nobase' in
> the %packages section. Given that this is possible via WebUI,
> fix this gap for the environments that want to create their
> kickstarts via API only.
> ---
> .../xmlrpc/kickstart/profile/ProfileHandler.java | 18
> ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git
> a/java/code/src/com/redhat/rhn/frontend/xmlrpc/kickstart/profile/ProfileHandler.java
> b/java/code/src/com/redhat/rhn/frontend/xmlrpc/kickstart/profile/ProfileHandler.java
> index 09bd801..46b033f 100644
> ---
> a/java/code/src/com/redhat/rhn/frontend/xmlrpc/kickstart/profile/ProfileHandler.java
> +++
> b/java/code/src/com/redhat/rhn/frontend/xmlrpc/kickstart/profile/ProfileHandler.java
> @@ -808,7 +808,8 @@ public class ProfileHandler extends BaseHandler {
> * timezone, auth, rootpw, selinux, reboot,
> firewall, xconfig, skipx,
> * key, ignoredisk, autopart, cmdline, firstboot,
> graphical, iscsi,
> * iscsiname, logging, monitor, multipath,
> poweroff, halt, services,
> - * shutdown, user, vnc, zfcp, driverdisk,
> md5_crypt_rootpw")
> + * shutdown, user, vnc, zfcp, driverdisk,
> md5_crypt_rootpw, nobase,
> + * ignoremissing")
> * #prop_desc("string", "arguments", "Arguments of the
> option")
> * #struct_end()
> * #array_end()
> @@ -833,7 +834,7 @@ public class ProfileHandler extends BaseHandler {
> "ignoredisk", "autopart", "cmdline", "firstboot",
> "graphical", "iscsi",
> "iscsiname", "logging", "monitor", "multipath",
> "poweroff", "halt",
> "services", "shutdown", "user", "vnc", "zfcp",
> "driverdisk",
> - "md5_crypt_rootpw"};
> + "md5_crypt_rootpw", "nobase", "ignoremissing"};
>
> List<String> validOptions = Arrays.asList(validOptionNames);
>
> @@ -867,6 +868,19 @@ public class ProfileHandler extends BaseHandler
> {
> requiredOptionNames);
> }
>
> + for (Map option : options) {
> + // nobase and ignoremissing are not proper
> kickstartoptioncommands so we need to
> + // parse them outside the
> KickstartOptionsCommand.getAvailableOptions() loop below
> + if (option.get("name").equals("nobase")) {
> + Boolean nobase =
> BooleanUtils.toBoolean((String)option.get("arguments"));
> + ksdata.setNoBase(nobase);
> + }
> + else if (option.get("name").equals("ignoremissing")) {
> + Boolean ignoremissing =
> BooleanUtils.toBoolean((String)option.get("arguments"));
> + ksdata.setIgnoreMissing(ignoremissing);
> + }
> + }
> +
> Set<KickstartCommand> customSet = new
> HashSet<KickstartCommand>();
>
> for (Iterator itr = cmd.getAvailableOptions().iterator();
> itr.hasNext();) {
> --
> 1.8.4.2
>
> _______________________________________________
> Spacewalk-devel mailing list
> Spacewalk-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-devel
>
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
