On 10/12/13 11:02, Tomáš Kašpárek wrote: > Hello, > > Hello as new Spacewalk webUI brought new icons with itself and many of > those icons are used at many places, scattered across entire webUI, some > effort would be required if any of those icons would need to be changed > for whatever reason (sure, nothing that grep and sed can't handle). For > this reason I've implemented new rhn:icon tag, so icon definitions like > "fa fa-check-circle fa-1-5x text-success" are all put at one place and > only this would need to be changed if any changes are needed. > I am not calling for using rhn:icon for every icon in Spacewalk > (espetialy those that are used only in one place), but if you know that > some icon is or will be used multiple times, please consider using the > new tag. It will make future changes easier ;-) > Syntax of the new tag is following: > > <rhn:icon type="system-ok" title="I am dangerous shark!" /> > > Type is mandatory and it must be one of the HashMap keys specified in > IconTag.java. Title is optional and as it's name says it will place > title for the icon. > > Any comments are welcome
I think it is a good idea, but if this would be the standard way, then we should port all the i class= tags. I have a tool to do this in case you are interested. -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
