Great finding, Robert! Do you think you'll be able to provide a PR on
github?
2018-05-23 16:13 GMT+02:00 Paschedag, Robert <paschedag.netlut...@swr.de>:
>
> Not needed anymore.
>
> I created a test SW 2.8 server here and can confirm, that the commit
> 43d11cc68a5c37967356e0ef583eeaf8e45b1820 breaks the "configure-proxy.sh"
> script.
>
> What I did was rebuild the spacewalk-java package (and subpackages) with
> that patch reverted.
>
> Then registering the proxy works as designed.
>
> What I did....
>
> - checked out the spacewalk-java-2.8.78 tag and reverted the commit and
> just increased the release (just to be greater)
>
> git log
>
> commit bf504b0d73abe9b8cc7b2609f8f0b5d069a9e3e3
> Author: Robert Paschedag <robert.pasche...@web.de>
> Date: Wed May 23 15:43:20 2018 +0200
>
> increased release
>
> commit c49a6665f67b7562050ded4cb086e14c814f5157
> Author: Robert Paschedag <robert.pasche...@web.de>
> Date: Wed May 23 15:41:49 2018 +0200
>
> Revert "ClientCertificate - make not publically used
> methods/attributes private"
>
> This reverts commit 43d11cc68a5c37967356e0ef583eeaf8e45b1820.
>
> commit 752a1e9f75908a136a5755ce5fbd4abac1e60084
> Author: Jiri Dostal <jdos...@redhat.com>
> Date: Wed Apr 18 13:42:49 2018 +0200
>
> Automatic commit of package [spacewalk-java] release [2.8.78-1].
>
>
> - rebuilt the package
>
> - installed the newer "spacewalk-java-lib" package on the spacewalk server
>
> [root@sw28-test lib]# rpm -qa | grep spacewalk-java
> spacewalk-java-lib-2.8.78-2.el6.noarch <== note the
> release number 2
> spacewalk-java-config-2.8.78-1.el6.noarch
> spacewalk-java-2.8.78-1.el6.noarch
> spacewalk-java-postgresql-2.8.78-1.el6.noarch
> [root@sw28-test lib]#
>
>
> - restarted the spacewalk services
>
> This is the output of "configure-proxy.sh"
>
> NOTE: This was all done on a CentOS 6 (6.9) system (both proxy and server)
>
> [root@sw-proxy-test ~]# configure-proxy.sh
> Using RHN parent (from /etc/sysconfig/rhn/up2date): sw28-test.domain
> Using CA Chain (from /etc/sysconfig/rhn/up2date): /usr/share/rhn/RHN-ORG-
> TRUSTED-SSL-CERT
> HTTP Proxy []:
> Proxy version to activate [2.8]:
> Traceback email []:
> Use SSL [Y/n]: y
> Regardless of whether you enabled SSL for the connection to the Spacewalk
> Parent
> Server, you will be prompted to generate an SSL certificate.
> This SSL certificate will allow client systems to connect to this
> Spacewalk Proxy
> securely. Refer to the Spacewalk Proxy Installation Guide for more
> information.
> Organization []: TEST
> Organization Unit [sw-proxy-test.domain]:
> Common Name [sw-proxy-test.domain]:
> City []: TEST
> State []: TEST
> Country code []: DE
> Email []:
> Cname aliases (separated by space) []:
> Spacewalk Proxy successfully activated.
> Shutting down rhn-proxy...
> Terminating jabberd processes ...
> Stopping s2s: [FAILED]
> Stopping c2s: [FAILED]
> Stopping sm: [FAILED]
> Stopping router: [FAILED]
> Stopping httpd: [ OK ]
> Stopping squid: [FAILED]
> Done.
> Loaded plugins: fastestmirror, rhnplugin
> This system is not subscribed to any channels.
> RHN channel support will be disabled.
> Setting up Install Process
> Repository group_spacewalkproject-java-packages is listed more than once
> in the configuration
> Repository group_spacewalkproject-epel6-addons is listed more than once
> in the configuration
> Loading mirror speeds from cached hostfile
> * base: centos.alpha-labs.net
> * epel: epel.mirror.far.fi
> * extras: centosmirror.netcup.net
> * updates: artfiles.org
> Package spacewalk-proxy-management-2.8.5-1.el6.noarch already installed
> and latest version
> Nothing to do
> Loaded plugins: fastestmirror, rhnplugin
> This system is not subscribed to any channels.
> RHN channel support will be disabled.
> Setting up Upgrade Process
> Repository group_spacewalkproject-java-packages is listed more than once
> in the configuration
> Repository group_spacewalkproject-epel6-addons is listed more than once
> in the configuration
> Loading mirror speeds from cached hostfile
> * base: centos.alpha-labs.net
> * epel: epel.mirror.far.fi
> * extras: centosmirror.netcup.net
> * updates: artfiles.org
> Resolving Dependencies
> --> Running transaction check
> ---> Package kernel.x86_64 0:2.6.32-696.30.1.el6 will be installed
> ---> Package kernel-firmware.noarch 0:2.6.32-696.28.1.el6 will be updated
> ---> Package kernel-firmware.noarch 0:2.6.32-696.30.1.el6 will be an update
> ---> Package python2-rhnlib.noarch 0:2.8.11-1.el6 will be obsoleting
> ---> Package rhnlib.noarch 0:2.8.10-1.el6 will be obsoleted
> --> Finished Dependency Resolution
>
> Dependencies Resolved
>
> ============================================================
> ============================================================
> ==============================
> Package Arch
> Version Repository
> Size
> ============================================================
> ============================================================
> ==============================
> Installing:
> kernel x86_64
> 2.6.32-696.30.1.el6 updates
> 32 M
> python2-rhnlib noarch
> 2.8.11-1.el6 spacewalk
> 71 k
> replacing rhnlib.noarch 2.8.10-1.el6
> Updating:
> kernel-firmware noarch
> 2.6.32-696.30.1.el6 updates
> 29 M
>
> Transaction Summary
> ============================================================
> ============================================================
> ==============================
> Install 2 Package(s)
> Upgrade 1 Package(s)
>
> Total download size: 61 M
> Is this ok [y/N]: y
> Downloading Packages:
> (1/3): kernel-2.6.32-696.30.1.el6.x86_64.rpm
> | 32 MB 00:01
> (2/3): kernel-firmware-2.6.32-696.30.1.el6.noarch.rpm
> | 29 MB 00:00
> (3/3): python2-rhnlib-2.8.11-1.el6.noarch.rpm
> | 71 kB 00:00
> ------------------------------------------------------------
> ------------------------------------------------------------
> ------------------------------
> Total
> 17 MB/s | 61 MB 00:03
> Running rpm_check_debug
> Running Transaction Test
> Transaction Test Succeeded
> Running Transaction
> Updating : kernel-firmware-2.6.32-696.30.1.el6.noarch
> 1/5
> Installing : kernel-2.6.32-696.30.1.el6.x86_64
> 2/5
> Installing : python2-rhnlib-2.8.11-1.el6.noarch
> 3/5
> Erasing : rhnlib-2.8.10-1.el6.noarch
> 4/5
> Cleanup : kernel-firmware-2.6.32-696.28.1.el6.noarch
> 5/5
> Verifying : kernel-firmware-2.6.32-696.30.1.el6.noarch
> 1/5
> Verifying : python2-rhnlib-2.8.11-1.el6.noarch
> 2/5
> Verifying : kernel-2.6.32-696.30.1.el6.x86_64
> 3/5
> Verifying : kernel-firmware-2.6.32-696.28.1.el6.noarch
> 4/5
> Verifying : rhnlib-2.8.10-1.el6.noarch
> 5/5
>
> Installed:
> kernel.x86_64 0:2.6.32-696.30.1.el6
> python2-rhnlib.noarch 0:2.8.11-1.el6
>
> Updated:
> kernel-firmware.noarch 0:2.6.32-696.30.1.el6
>
> Replaced:
> rhnlib.noarch 0:2.8.10-1.el6
>
> Complete!
> Using CA key at /root/ssl-build/RHN-ORG-PRIVATE-SSL-KEY.
> Generating distributable RPM for CA public certificate:
> Copying CA public certificate to /var/www/html/pub for distribution to
> clients:
> Generating SSL key and public certificate:
> CA password:
> Installing SSL certificate for Apache and Jabberd:
> Preparing packages for installation...
> rhn-org-httpd-ssl-key-pair-sw-proxy-test-1.0-1
> Create and populate configuration channel rhn_proxy_config_1000010000?
> [Y/n]: n
> Enabling Spacewalk Proxy.
> Shutting down rhn-proxy...
> Terminating jabberd processes ...
> Stopping s2s: [FAILED]
> Stopping c2s: [FAILED]
> Stopping sm: [FAILED]
> Stopping router: [FAILED]
> Stopping httpd: [ OK ]
> Stopping squid: [FAILED]
> Done.
> Starting rhn-proxy...
> init_cache_dir /var/spool/squid... Starting squid: . [ OK ]
> Starting httpd: [ OK ]
> Initializing jabberd processes ...
> Starting router: [ OK ]
> Starting sm: [ OK ]
> Starting c2s: [ OK ]
> Starting s2s: [ OK ]
> Done.
> There were some answers you had to enter manually.
> Would you like to have written those into file
> formatted as answers file? [Y/n]: y
> Writing proxy-answers.txt.V6vDw
> [root@sw-proxy-test ~]#
>
> [root@sw28-test lib]# spacewalk-sql -i
> psql (8.4.20)
> Type "help" for help.
>
> rhnschema=# select * from rhnproxyinfo;
> server_id | proxy_evr_id
> ------------+--------------
> 1000010000 | 176
> (1 row)
>
> rhnschema=# \q
> [root@sw28-test lib]#
>
> Cheers,
> Robert
>
>
>
> ------------------------------
> *Von:* spacewalk-list-boun...@redhat.com <spacewalk-list-bounces@
> redhat.com> im Auftrag von Angelo Lisco <angystard...@gmail.com>
> *Gesendet:* Mittwoch, 23. Mai 2018 15:27
>
> *An:* spacewalk-list@redhat.com
> *Betreff:* Re: [Spacewalk-list] Spacewalk 2.8 configure-proxy.sh Error
>
> Hi Robert,
> unfortunately my SW 2.8 is a production server and I would like not to
> break it.
> Maybe I can take a snapshot of the vm before testing the downgrade and
> test if it fix the issue.
> By the way, I cannot find the 2.8.28-1 version of the package in the 2.8
> report
>
>
> 2018-05-23 10:58 GMT+02:00 Paschedag, Robert <paschedag.netlut...@swr.de>:
>
> Angelo,
>
>
> is your SW 2.8 a "dev" or "test" server?
>
>
> If yes, maybe you could try to downgrade the "spacewalk-java-lib" package
> on your server to version 2.8.28-1
>
>
> spacewalk-java-lib contains the "rhn.jar" which itself contains the
> "ClientCertificate.class" that I ***think*** that causes the error (see
> part of the changelog of "java/spacewalk-java.spec")
>
>
> ...
>
> * Tue Oct 17 2017 Tomas Kasparek <tkaspa...@redhat.com> 2.8.29-1
> - remove no longer needed imports
> - use inline variables when possible
> - return as last statement in void function is pointless
> - continue doesn't make sense as last command in loop
> - don't use ternary operator where it's not necessary
> - .equals already returns boolean value
> - simplify if (true) { return true; } else { return false; } expressions
> - use .equals instead of ==
> - get rid of empty if blocks
> - fix javadoc comment with correct method signature
> - call methods from ConfigDefaults to ensure default value is used instead
> of 0
> - ConfigDefaults - simplify return statement
> - ConfigDefaults - make publically not used attributes private
> - Config - use foreach loop where it makes sense
> - Config - make publically not used attributes private
> - ClientCertificate - use foreach loop
> - ClientCertificate - make not publically used methods/attributes private
> <== I think this causes the error in configure-proxy.sh
> - super() class exception is already thrown
> - simplify if (true) { return true; } else { return false; } expressions
> - return is not needed in void functions
> - expression can be written without ternary operator
>
> * Mon Oct 16 2017 Jan Dobes 2.8.28-1
> - do not forcibly include @ Base pkg group into package list
> - remove unused variable
> - making snippets compatible with Python 3
> - these packages are necessary on Fedora too
> - fixing typo
>
> * Mon Oct 16 2017 Tomas Kasparek <tkaspa...@redhat.com> 2.8.27-1
>
> spacewalk-java-lib contains...
>
>
> /usr/share/rhn/classes/log4j.properties
> /usr/share/rhn/lib/rhn.jar
>
> So in case you want to *try to downgrade*, make sure you save the
> "log4j.properties". Downgrading this package might rise other problems.
>
> Again....try this only on NON productive server. My playground, where I
> confirmed the error, is at home. But I will - myself - try to downgrade the
> package there this evening.
>
> Robert
>
>
> ------------------------------
> *Von:* spacewalk-list-boun...@redhat.com <spacewalk-list-bounces@
> redhat.com> im Auftrag von Paschedag, Robert <paschedag.netlut...@swr.de>
> *Gesendet:* Mittwoch, 23. Mai 2018 10:22
> *An:* spacewalk-list@redhat.com
> *Betreff:* Re: [Spacewalk-list] Spacewalk 2.8 configure-proxy.sh Error
>
>
> Hi spacewalkers,
>
>
> Avi gave me a hint, that the current client (I'm using here right now)
> messes the messages up and it looks like I'm sending empty responses.
>
>
> Sorry for that.
>
>
> I'll try to keep "top posting" (from here) from now on.
>
>
> Robert
>
>
>
>
> ------------------------------
> *Von:* spacewalk-list-boun...@redhat.com <spacewalk-list-bounces@
> redhat.com> im Auftrag von Paschedag, Robert <paschedag.netlut...@swr.de>
> *Gesendet:* Mittwoch, 23. Mai 2018 08:37
> *An:* spacewalk-list@redhat.com
> *Betreff:* Re: [Spacewalk-list] Spacewalk 2.8 configure-proxy.sh Error
>
>
>
>
>
> ------------------------------
> *Von:* spacewalk-list-boun...@redhat.com <spacewalk-list-bounces@
> redhat.com> im Auftrag von Angelo Lisco <angystard...@gmail.com>
> *Gesendet:* Dienstag, 22. Mai 2018 21:55
> *Cc:* spacewalk-list@redhat.com
> *Betreff:* Re: [Spacewalk-list] Spacewalk 2.8 configure-proxy.sh Error
>
> WARNING: redstone.xmlrpc.XmlRpcFault: method invalid param
> That's exactly the same error I get!
> Still finding how to fix it but I suspect that there's an issue in the
> entitlement code
>
> Il Mar 22 Mag 2018, 21:51 Robert Paschedag <robert.pasche...@web.de> ha
> scritto:
>
> Am 22.05.2018 um 09:32 schrieb Paschedag, Robert:
> >
> >
> >
> > ------------------------------------------------------------------------
> > *Von:* spacewalk-list-boun...@redhat.com
> > <spacewalk-list-boun...@redhat.com> im Auftrag von Robert Paschedag
> > <robert.pasche...@web.de>
> > *Gesendet:* Montag, 21. Mai 2018 23:29
> > *An:* spacewalk-list@redhat.com; Angelo Lisco
> > *Betreff:* Re: [Spacewalk-list] Spacewalk 2.8 configure-proxy.sh Error
> >
> > On 05/21/18 20:01, Angelo Lisco wrote:
> >> ok, i've found a bugzilla report here:
> >>
> > https://emea01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fbugzilla.redhat.com%2Fshow_bug.cgi%3Fid%
> 3D1575906&data=02%7C01%7CPaschedag.Netlution%40swr.de%
> 7C3e702af8b5f644be31f508d5bf62000f%7Cbcca095d88d442f88260cc216b81
> f62d%7C0%7C0%7C636625349990724050&sdata=xqT7eiymLxFx2taIIm%
> 2FpF0VfOE3x2F94vWVJQEIVu6M%3D&reserved=0
> >> It's assigned to Tomáš Kašpárek <tkaspa...@redhat.com> but still no
> >> feedback from him :(
> >>
> >> 2018-05-21 19:07 GMT+02:00 Angelo Lisco <angystard...@gmail.com>:
> >>
> >>> Hi Stuart,
> >>> I'm experiencing the same issue here. Did you find a solution to this
> >>> problem?
> >>>
> >>> Thanks.
> >>> Angelo
> >>>
> >>> 2018-04-24 14:49 GMT+02:00 Stuart Wilson <stu...@432solutions.co.uk>:
> >>>
> >>>> Hi,
> >>>>
> >>>> I’m currently trying to setup a Spacewalk proxy instance on a RHEL 7.4
> >>>> server. I followed the guide as per the Wiki (
> >>>>
> > https://emea01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fspacewalkproject%2Fspacewalk%2Fwiki%
> 2FHowToInstallProxy&data=02%7C01%7CPaschedag.Netlution%40swr.de%
> 7C3e702af8b5f644be31f508d5bf62000f%7Cbcca095d88d442f88260cc216b81
> f62d%7C0%7C0%7C636625349990724050&sdata=K%2FDkxvi71%2Bksw1%2F1HjZcRAaw%
> 2FRU1zCfdb26mhKS%2Fd5U%3D&reserved=0),
> >>>> however when I run configure-proxy.sh, I’m getting the error “WARNING:
> >>>> upon deactivation attempt: uknown error – <Fault -12:
> >>>> ‘redstone.xmlrpc.XmlRpcFault: method invalid param’>”. I managed to
> > track
> >>>> this down to the call using rhn-proxy-activate within
> > configure-proxy.sh.
> >>>> Tracing it back to the main Spacewalk server, the Web-API log shows
> the
> >>>> same error, “method invalid param” while trying to call the
> >>>> proxy.list_available_proxy_channels method.
> >>>>
> >>>> Has anyone else seen this error before, I’m not really sure where to
> > move
> >>>> forward with this, is this something that’s changed in the latest 2.8
> >>>> version of spacewalk? Or could this be something to do with
> > “Provisioning
> >>>> Entitlements”, I understand they were changed back in 2.5, but I
> > can’t find
> >>>> any documentation on how they are enabled nowadays, though the
> >>>> documentation does still refer to them being needed. Any help, much
> >>>> appreciated.
> >>>>
> >>>> Thanks,
> >>>>
> >>>>
> >>>> Stuart.
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> Spacewalk-list mailing list
> >>>> Spacewalk-list@redhat.com
> >>>>
> > https://emea01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.redhat.com%2Fmailman%2Flistinfo%
> 2Fspacewalk-list&data=02%7C01%7CPaschedag.Netlution%40swr.de%
> 7C3e702af8b5f644be31f508d5bf62000f%7Cbcca095d88d442f88260cc216b81
> f62d%7C0%7C0%7C636625349990724050&sdata=RIHHQ5Gc5c%2B4kZKq6uBHnEd806KY6%
> 2BsqTQzh8WSHZ%2BI%3D&reserved=0
> >>>>
> >>>
> >>>
> >>
> >>
> >>
> >> _______________________________________________
> >> Spacewalk-list mailing list
> >> Spacewalk-list@redhat.com
> >>
> > https://emea01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.redhat.com%2Fmailman%2Flistinfo%
> 2Fspacewalk-list&data=02%7C01%7CPaschedag.Netlution%40swr.de%
> 7C3e702af8b5f644be31f508d5bf62000f%7Cbcca095d88d442f88260cc216b81
> f62d%7C0%7C0%7C636625349990724050&sdata=RIHHQ5Gc5c%2B4kZKq6uBHnEd806KY6%
> 2BsqTQzh8WSHZ%2BI%3D&reserved=0
> >>
> >
> > Seems to be this part here (in proxy/installer/rhn-proxy-activate.py)
> >
> > s = getServer(options, DEFAULT_WEBRPC_HANDLER_v3_x)
> > systemid = getSystemId(cfg)
> >
> > errorCode, errorString = 0, ''
> >
> > try:
> > if not s.proxy.is_proxy(systemid):
> > # if system is not proxy, we do not need to deactivate it
> > return (errorCode, errorString)
> > except: # pylint: disable=W0702
> > # api do not have proxy.is_proxy is implemented or it is hosted
> > # ignore error and try to deactivate
> > pass
> > try:
> > s.proxy.deactivate_proxy(systemid) # proxy 3.0+ API
> > except: # pylint: disable=W0702
> > errorCode, errorString = _errorHandler()
> > try:
> > raise
> > except xmlrpclib.Fault:
> > if errorCode == 8:
> > # fine. We weren't activated yet.
> > # noop and look like a success
> > errorCode = 0
> > else:
> > errorString = "WARNING: upon deactivation attempt: %s" %
> > errorString
> > :
> >
> > I think, the main problem is, that "is_proxy()" cannot be called (throws
> > an error, at least, if there really is no proxy with that systemID).
> >
> > Thus,
> >
> > s.proxy.deactivate_proxy(systemid)
> >
> > get's called. I cannot find this code ("deactivate_proxy"), except in
> > this script, thus this might also throw an exception.
> >
> > But this is all speculative. I cannot test this "proxy" activation here.
> >
> > "is_proxy" can also be found in
> >
> > java/code/src/com/redhat/rhn/common/db/datasource/xml/System_queries.xml
> >
> >
> > <mode name="is_proxy">
> > <query params="sid">
> > SELECT 1
> > FROM rhnProxyInfo PI
> > WHERE PI.server_id=:sid
> > </query>
> > </mode>
> >
> >
> > Robert
> >
> >
> > Greping through the logs....I only found this old commit
> >
> > git log -i --grep deactivate_proxy
> > commit e5d511008fe8bd1d8e49519cea06322da1fdcc89
> > Author: Miroslav Suchý <msu...@redhat.com>
> > Date: Wed Dec 7 20:29:35 2011 +0100
> >
> > code cleanup - deactivate_proxy() is not used anymore
> >
> > Robert
> >
> > _______________________________________________
> > Spacewalk-list mailing list
> > Spacewalk-list@redhat.com
> > https://emea01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.redhat.com%2Fmailman%2Flistinfo%
> 2Fspacewalk-list&data=02%7C01%7CPaschedag.Netlution%40swr.de%
> 7C3e702af8b5f644be31f508d5bf62000f%7Cbcca095d88d442f88260cc216b81
> f62d%7C0%7C0%7C636625349990724050&sdata=RIHHQ5Gc5c%2B4kZKq6uBHnEd806KY6%
> 2BsqTQzh8WSHZ%2BI%3D&reserved=0
> >
> >
> > _______________________________________________
> > Spacewalk-list mailing list
> > Spacewalk-list@redhat.com
> > https://www.redhat.com/mailman/listinfo/spacewalk-list
> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.redhat.com%2Fmailman%2Flistinfo%2Fspacewalk-list&data=02%7C01%7CPaschedag.Netlution%40swr.de%7C919fa68dc0e34dbb391008d5c01e2c3f%7Cbcca095d88d442f88260cc216b81f62d%7C0%7C1%7C636626158190411411&sdata=rZHCopREuRm%2FsydGWQDAEXGPocGRcO40XWLZhDE9wDg%3D&reserved=0>
> >
>
> I now build a test environment with SW 2.8 and trying to connect a proxy
> 2.8 to it. Get the same error
>
> rhn-activate-proxy thows an error at
>
> if not s.proxy.is_proxy(systemid):
>
>
> 2018-05-22 21:45:49,208 [TP-Processor8] ERROR
> org.apache.commons.digester.Digester - End event threw exception
> java.lang.NoSuchMethodException: No such accessible method: addMember()
> on object: com.redhat.rhn.common.client.ClientCertificate
> at
> org.apache.commons.beanutils.MethodUtils.invokeMethod(
> MethodUtils.java:276)
> at org.apache.commons.digester.SetNextRule.end(SetNextRule.
> java:217)
> at org.apache.commons.digester.Rule.end(Rule.java:253)
> at org.apache.commons.digester.Digester.endElement(Digester.
> java:1233)
> at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown
> Source)
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl
> .scanEndElement(Unknown
> Source)
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl
> $FragmentContentDispatcher.dispatch(Unknown
> Source)
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
> Source)
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> Source)
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> Source)
> at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
> at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown
> Source)
> at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown
> Source)
> at org.apache.commons.digester.Digester.parse(Digester.java:1812)
> at
> com.redhat.rhn.common.client.ClientCertificateDigester.buildCertificate(
> ClientCertificateDigester.java:80)
> at
> com.redhat.rhn.frontend.xmlrpc.BaseHandler.validateClientCertificate(
> BaseHandler.java:441)
> at
> com.redhat.rhn.frontend.xmlrpc.proxy.ProxyHandler.
> isProxy(ProxyHandler.java:76)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at com.redhat.rhn.frontend.xmlrpc.BaseHandler.invoke(
> BaseHandler.java:142)
> at redstone.xmlrpc.XmlRpcDispatcher.dispatch(
> XmlRpcDispatcher.java:123)
> at
> com.redhat.rhn.frontend.xmlrpc.RhnXmlRpcServer.
> execute(RhnXmlRpcServer.java:54)
> at
> com.redhat.rhn.frontend.xmlrpc.XmlRpcServlet.doPost(
> XmlRpcServlet.java:162)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:643)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:290)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.opensymphony.sitemesh.webapp.SiteMeshFilter.
> obtainContent(SiteMeshFilter.java:129)
> at
> com.opensymphony.sitemesh.webapp.SiteMeshFilter.
> doFilter(SiteMeshFilter.java:77)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.LocalizedEnvironmentFilter.doFilter(
> LocalizedEnvironmentFilter.java:67)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.EnvironmentFilter.
> doFilter(EnvironmentFilter.java:101)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.SessionFilter.
> doFilter(SessionFilter.java:58)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.SetCharacterEncodingFilter.doFilter(
> SetCharacterEncodingFilter.java:97)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(
> StandardWrapperValve.java:233)
> at
> org.apache.catalina.core.StandardContextValve.invoke(
> StandardContextValve.java:191)
> at
> org.apache.catalina.core.StandardHostValve.invoke(
> StandardHostValve.java:127)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(
> ErrorReportValve.java:102)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(
> StandardEngineValve.java:109)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(
> CoyoteAdapter.java:299)
> at org.apache.jk.server.JkCoyoteHandler.invoke(
> JkCoyoteHandler.java:190)
> at org.apache.jk.common.HandlerRequest.invoke(
> HandlerRequest.java:291)
> at org.apache.jk.common.ChannelSocket.invoke(
> ChannelSocket.java:769)
> at
> org.apache.jk.common.ChannelSocket.processConnection(
> ChannelSocket.java:698)
> at
> org.apache.jk.common.ChannelSocket$SocketConnection.runIt(
> ChannelSocket.java:891)
> at
> org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(
> ThreadPool.java:690)
> at java.lang.Thread.run(Thread.java:748)
> 2018-05-22 21:45:49,208 [TP-Processor8] ERROR
> com.redhat.rhn.frontend.xmlrpc.BaseHandler - SAXException - Trying to
> access a system with an invalid certificate
> org.xml.sax.SAXParseException; lineNumber: 8; columnNumber: 10; Error at
> line 8 char 10: No such accessible method: addMember() on object:
> com.redhat.rhn.common.client.ClientCertificate
> at
> org.apache.commons.digester.Digester.createSAXException(
> Digester.java:3223)
> at
> org.apache.commons.digester.Digester.createSAXException(
> Digester.java:3249)
> at org.apache.commons.digester.Digester.endElement(Digester.
> java:1236)
> at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown
> Source)
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl
> .scanEndElement(Unknown
> Source)
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl
> $FragmentContentDispatcher.dispatch(Unknown
> Source)
> at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
> Source)
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> Source)
> at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> Source)
> at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
> at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown
> Source)
> at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown
> Source)
> at org.apache.commons.digester.Digester.parse(Digester.java:1812)
> at
> com.redhat.rhn.common.client.ClientCertificateDigester.buildCertificate(
> ClientCertificateDigester.java:80)
> at
> com.redhat.rhn.frontend.xmlrpc.BaseHandler.validateClientCertificate(
> BaseHandler.java:441)
> at
> com.redhat.rhn.frontend.xmlrpc.proxy.ProxyHandler.
> isProxy(ProxyHandler.java:76)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at com.redhat.rhn.frontend.xmlrpc.BaseHandler.invoke(
> BaseHandler.java:142)
> at redstone.xmlrpc.XmlRpcDispatcher.dispatch(
> XmlRpcDispatcher.java:123)
> at
> com.redhat.rhn.frontend.xmlrpc.RhnXmlRpcServer.
> execute(RhnXmlRpcServer.java:54)
> at
> com.redhat.rhn.frontend.xmlrpc.XmlRpcServlet.doPost(
> XmlRpcServlet.java:162)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:643)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:290)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.opensymphony.sitemesh.webapp.SiteMeshFilter.
> obtainContent(SiteMeshFilter.java:129)
> at
> com.opensymphony.sitemesh.webapp.SiteMeshFilter.
> doFilter(SiteMeshFilter.java:77)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.LocalizedEnvironmentFilter.doFilter(
> LocalizedEnvironmentFilter.java:67)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.EnvironmentFilter.
> doFilter(EnvironmentFilter.java:101)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.SessionFilter.
> doFilter(SessionFilter.java:58)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.SetCharacterEncodingFilter.doFilter(
> SetCharacterEncodingFilter.java:97)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(
> StandardWrapperValve.java:233)
> at
> org.apache.catalina.core.StandardContextValve.invoke(
> StandardContextValve.java:191)
> at
> org.apache.catalina.core.StandardHostValve.invoke(
> StandardHostValve.java:127)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(
> ErrorReportValve.java:102)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(
> StandardEngineValve.java:109)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(
> CoyoteAdapter.java:299)
> at org.apache.jk.server.JkCoyoteHandler.invoke(
> JkCoyoteHandler.java:190)
> at org.apache.jk.common.HandlerRequest.invoke(
> HandlerRequest.java:291)
> at org.apache.jk.common.ChannelSocket.invoke(
> ChannelSocket.java:769)
> at
> org.apache.jk.common.ChannelSocket.processConnection(
> ChannelSocket.java:698)
> at
> org.apache.jk.common.ChannelSocket$SocketConnection.runIt(
> ChannelSocket.java:891)
> at
> org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(
> ThreadPool.java:690)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.NoSuchMethodException: No such accessible method:
> addMember() on object: com.redhat.rhn.common.client.ClientCertificate
> at
> org.apache.commons.beanutils.MethodUtils.invokeMethod(
> MethodUtils.java:276)
> at org.apache.commons.digester.SetNextRule.end(SetNextRule.
> java:217)
> at org.apache.commons.digester.Rule.end(Rule.java:253)
> at org.apache.commons.digester.Digester.endElement(Digester.
> java:1233)
> ... 54 more
> 2018-05-22 21:45:49,210 [TP-Processor8] ERROR
> com.redhat.rhn.frontend.xmlrpc.BaseHandler - Error calling method:
> java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at com.redhat.rhn.frontend.xmlrpc.BaseHandler.invoke(
> BaseHandler.java:142)
> at redstone.xmlrpc.XmlRpcDispatcher.dispatch(
> XmlRpcDispatcher.java:123)
> at
> com.redhat.rhn.frontend.xmlrpc.RhnXmlRpcServer.
> execute(RhnXmlRpcServer.java:54)
> at
> com.redhat.rhn.frontend.xmlrpc.XmlRpcServlet.doPost(
> XmlRpcServlet.java:162)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:643)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:290)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.opensymphony.sitemesh.webapp.SiteMeshFilter.
> obtainContent(SiteMeshFilter.java:129)
> at
> com.opensymphony.sitemesh.webapp.SiteMeshFilter.
> doFilter(SiteMeshFilter.java:77)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.LocalizedEnvironmentFilter.doFilter(
> LocalizedEnvironmentFilter.java:67)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.EnvironmentFilter.
> doFilter(EnvironmentFilter.java:101)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.SessionFilter.
> doFilter(SessionFilter.java:58)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.SetCharacterEncodingFilter.doFilter(
> SetCharacterEncodingFilter.java:97)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(
> StandardWrapperValve.java:233)
> at
> org.apache.catalina.core.StandardContextValve.invoke(
> StandardContextValve.java:191)
> at
> org.apache.catalina.core.StandardHostValve.invoke(
> StandardHostValve.java:127)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(
> ErrorReportValve.java:102)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(
> StandardEngineValve.java:109)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(
> CoyoteAdapter.java:299)
> at org.apache.jk.server.JkCoyoteHandler.invoke(
> JkCoyoteHandler.java:190)
> at org.apache.jk.common.HandlerRequest.invoke(
> HandlerRequest.java:291)
> at org.apache.jk.common.ChannelSocket.invoke(
> ChannelSocket.java:769)
> at
> org.apache.jk.common.ChannelSocket.processConnection(
> ChannelSocket.java:698)
> at
> org.apache.jk.common.ChannelSocket$SocketConnection.runIt(
> ChannelSocket.java:891)
> at
> org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(
> ThreadPool.java:690)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: com.redhat.rhn.frontend.xmlrpc.MethodInvalidParamException:
> method invalid param
> at
> com.redhat.rhn.frontend.xmlrpc.BaseHandler.validateClientCertificate(
> BaseHandler.java:452)
> at
> com.redhat.rhn.frontend.xmlrpc.proxy.ProxyHandler.
> isProxy(ProxyHandler.java:76)
> ... 41 more
> 2018-05-22 21:45:49,216 [TP-Processor8] ERROR
> com.redhat.rhn.frontend.xmlrpc.BaseHandler - Caused by:
> com.redhat.rhn.frontend.xmlrpc.MethodInvalidParamException: method
> invalid param
> at
> com.redhat.rhn.frontend.xmlrpc.BaseHandler.validateClientCertificate(
> BaseHandler.java:452)
> at
> com.redhat.rhn.frontend.xmlrpc.proxy.ProxyHandler.
> isProxy(ProxyHandler.java:76)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at com.redhat.rhn.frontend.xmlrpc.BaseHandler.invoke(
> BaseHandler.java:142)
> at redstone.xmlrpc.XmlRpcDispatcher.dispatch(
> XmlRpcDispatcher.java:123)
> at
> com.redhat.rhn.frontend.xmlrpc.RhnXmlRpcServer.
> execute(RhnXmlRpcServer.java:54)
> at
> com.redhat.rhn.frontend.xmlrpc.XmlRpcServlet.doPost(
> XmlRpcServlet.java:162)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:643)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:290)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.opensymphony.sitemesh.webapp.SiteMeshFilter.
> obtainContent(SiteMeshFilter.java:129)
> at
> com.opensymphony.sitemesh.webapp.SiteMeshFilter.
> doFilter(SiteMeshFilter.java:77)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.LocalizedEnvironmentFilter.doFilter(
> LocalizedEnvironmentFilter.java:67)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.EnvironmentFilter.
> doFilter(EnvironmentFilter.java:101)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.SessionFilter.
> doFilter(SessionFilter.java:58)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> com.redhat.rhn.frontend.servlets.SetCharacterEncodingFilter.doFilter(
> SetCharacterEncodingFilter.java:97)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:235)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:206)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(
> StandardWrapperValve.java:233)
> at
> org.apache.catalina.core.StandardContextValve.invoke(
> StandardContextValve.java:191)
> at
> org.apache.catalina.core.StandardHostValve.invoke(
> StandardHostValve.java:127)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(
> ErrorReportValve.java:102)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(
> StandardEngineValve.java:109)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(
> CoyoteAdapter.java:299)
> at org.apache.jk.server.JkCoyoteHandler.invoke(
> JkCoyoteHandler.java:190)
> at org.apache.jk.common.HandlerRequest.invoke(
> HandlerRequest.java:291)
> at org.apache.jk.common.ChannelSocket.invoke(
> ChannelSocket.java:769)
> at
> org.apache.jk.common.ChannelSocket.processConnection(
> ChannelSocket.java:698)
> at
> org.apache.jk.common.ChannelSocket$SocketConnection.runIt(
> ChannelSocket.java:891)
> at
> org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(
> ThreadPool.java:690)
> at java.lang.Thread.run(Thread.java:748)
> 2018-05-22 21:45:49,217 [TP-Processor8] ERROR
> com.redhat.rhn.frontend.xmlrpc.BaseHandler - Rolling back transaction
> May 22, 2018 9:45:49 PM redstone.xmlrpc.XmlRpcDispatcher writeError
> WARNING: redstone.xmlrpc.XmlRpcFault: method invalid param
>
> Robert
>
> Hi Tomas,
>
>
> because of this error
>
>
> 2018-05-22 21:45:49,208 [TP-Processor8] ERROR
> org.apache.commons.digester.Digester - End event threw exception
> java.lang.NoSuchMethodException: No such accessible method: addMember()
> on object: com.redhat.rhn.common.client.ClientCertificate
> at
>
>
> possibly this commit??
>
>
> commit 43d11cc68a5c37967356e0ef583eeaf8e45b1820
> Author: Tomas Kasparek <tkaspa...@redhat.com>
> Date: Tue Oct 17 10:27:44 2017 +0200
>
> ClientCertificate - make not publically used methods/attributes private
>
> diff --git a/java/code/src/com/redhat/rhn/common/client/ClientCertificate.java
> b/java/code/src/com/redhat/rhn/common/client/ClientCertificate.java
> index aa73782c1a..f7fe2a7a73 100644
> --- a/java/code/src/com/redhat/rhn/common/client/ClientCertificate.java
> +++ b/java/code/src/com/redhat/rhn/common/client/ClientCertificate.java
> @@ -35,7 +35,7 @@ import java.util.Map;
> public class ClientCertificate {
>
> public static final String SYSTEM_ID = "system_id";
> - public static final String FIELDS = "fields";
> + private static final String FIELDS = "fields";
> private final List<Member> members;
> private final Map<String, String[]> byName;
> private final Map<String, String> checksumFields;
> @@ -87,7 +87,7 @@ public class ClientCertificate {
> * Add a member to the certificate.
> * @param member Member to be added.
> */
> - public void addMember(Member member) {
> + private void addMember(Member member) {
> members.add(member);
> byName.put(member.getName(), member.getValues());
> }
>
>
> The "addMember(Member member) is "private" now. All others are still
> "public"
>
>
> Robert
>
>
>
> _______________________________________________
> Spacewalk-list mailing list
> Spacewalk-list@redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-list
> <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.redhat.com%2Fmailman%2Flistinfo%2Fspacewalk-list&data=02%7C01%7CPaschedag.Netlution%40swr.de%7Ce46a5dae17bc43aa9fa508d5c0b1cb5c%7Cbcca095d88d442f88260cc216b81f62d%7C0%7C0%7C636626792227665063&sdata=j6HHdyrDhpaNnclaZ2jOKdWwMT%2F68u567gMEd1TWAIk%3D&reserved=0>
>
>
>
> _______________________________________________
> Spacewalk-list mailing list
> Spacewalk-list@redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-list
>
_______________________________________________
Spacewalk-list mailing list
Spacewalk-list@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-list
