I have a patch to fix bug #2959 in spamc.c
http://bugzilla.spamassassin.org/show_bug.cgi?id=2959

The test case is to give spamc a nonexistent host, as in
 spamc -d foo.example.com < sample.nonspam.txt

While tracking it down I found that running under Windows after the bug is fixed spamc dies on an assert in that test case because stdin and stdout are in text mode, converting newlines and breaking the assert that the message size in and out is unchanged. The fix is to switch stdin and stdout to binary mode when in WIN32.

I also found a few compiler warnings that I fixed.

The extra stuff is just a handful of lines of code.

My question is, do I submit all of that in the patch for 2959 or do I open two other bug reports, and if the latter do I submit separate patches against current head for each of them and let whoever deals with it merge them separately?

 -- sidney



Reply via email to