-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Quinlan writes:
>Sidney Markowitz <[EMAIL PROTECTED]> writes:
>
>> Ok, I just went ahead and uploaded a patch that fixes all three issues. 
>> I hope that is fine.
>
>It's okay to fix a minor bug or two in the same file as long as it's
>semi-related, but if it's unrelated or the patch is hard to follow
>already, then it's best to use separate patches.  It's a judgement call,
>the only risk is that a committer might ask you to resubmit.  :-)

Yeah.  Typically it's only an issue if the secondary fixes are large
in terms of lines of code, or touch a lot of code across other
parts of the files, or require some kind of API redesign.

Judgement calls, really...

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFAEv16QTcbUG5Y7woRApBJAJ9xAPbKGHMBWpWFw/TpnYbzFnoUWwCg4dKV
Grxo6Dpf46jhSAT2ETsJdnU=
=Em0/
-----END PGP SIGNATURE-----

Reply via email to