http://bugzilla.spamassassin.org/show_bug.cgi?id=3050
------- Additional Comments From [EMAIL PROTECTED] 2004-02-17 12:42 ------- Subject: Re: mime parser debug output is screwed up sometimes! On Tue, Feb 17, 2004 at 11:04:35AM -0800, [EMAIL PROTECTED] wrote: > we do not want it to be a full SA object; all people expect to get from > a completed check() is: > > 1. the text of the message as headers and body > 2. the get_report() lines > 3. the get_names_of_tests_hit() string > 4. the get_hits() string Then why not return an associative array? Be pretty simple to do I'd think. > So should we change the API of rewrite_mail() to return just scalars? or a > new > object that supports the get APIs we had previously defined in > Mail::SpamAssassin::Message? (I'd prefer to avoid API breakage if we can, > because it'll be a total PITA for users of these classes.) Well, I don't want to introduce yet another object just to handle this situation. I'd say we should either just return the scalar or an associative array with the appropriately values there. Or even better ... return one or the other depending on wantarray ... Let the caller decide how much data to get back. :) ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
