http://bugzilla.spamassassin.org/show_bug.cgi?id=3113

[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |major
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From [EMAIL PROTECTED]  2004-03-01 15:02 -------
Oops.  I should appologize.  For this whole time I thought you meant in terms 
of check(), but you're 
talking about "report_safe 0" output.  Doh!  Sorry about that.   Yeah, in 
looking at the code, the rewrite 
function should definitely strip out the original X-Spam-* headers -- I don't 
know why that wasn't in 
there actually.

- I don't find in Changes where this (serious) change of 
  behaviour is mentioned

3.0 isn't released, so the Changes file hasn't been updated.

- There is a call to $self->{msg}->delete_header('X-Spam-.*') in 
  PerMsgstatus. What does this achieve if the intended purpose is 
  not what a superficial reading implies (and earlier SA versions 
  actually did at the same place)?

that check() doesn't see the x-spam headers.

- If old headers shouldn't be deleted, renaming them to something like 
  X-Old-Spam-* sounds like an easy solution.

for report_safe 0, we should just grep out the X-Spam headers.  I'm not sure 
why that wasn't being 
done before actually (it should have been in there...), but it's committed now. 
:)

"I would kindly urge you to rethink this design decision since it created 
huge problems."

since 3.0 isn't released, it hasn't created any problems afaik.  don't run 
devel releases in production. ;)



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to