-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Theo Van Dinter writes:
> On Wed, Mar 10, 2004 at 05:58:38AM -0000, [EMAIL PROTECTED] wrote:
> > Author: jm
> > Date: Tue Mar  9 21:58:37 2004
> > New Revision: 9337
> >  
> > +sub check_message_text {
> > +  my ($self, $mailtext) = @_;
> > +  my $msg = $self->parse($mailtext, 1);
> > +  return $self->check($msg);
> > +}
> 
> I think I removed this the last time I went cleaning ...  We have nothing
> that calls this function, so why is it here?  Doubly so since it causes
> a memory leak ($msg->finish() isn't called...) unless whoever calls it
> exits before checking another mail.

Because it's a public, supported API, used by at least 2 apps that use the
M:SpamAssassin perl API that I know of, and probably more.

- -1 on removing it ;)   I'll figure out some way to avoid the leak.

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFAT2t3QTcbUG5Y7woRArlkAJ4/p0VJLCvpyM/5Nsvv6Wj/OC3nSgCgpveQ
EAG5lreLG8Zni6k4+fyJxdo=
=GuY5
-----END PGP SIGNATURE-----

Reply via email to