http://bugzilla.spamassassin.org/show_bug.cgi?id=2912





------- Additional Comments From [EMAIL PROTECTED]  2004-03-15 10:15 -------
Subject: Re:  [review] RFE: allow test order to be controlling using a test 
'priority' setting

Well, I found a problem with the plugin interaction.  Specifically
this section in URIDNSBL::parsed_metadata:

  # only hit DNSBLs for which score != 0
  foreach my $rulename (keys %{$scanner->{conf}->{uridnsbls}}) {
    # trim_rules() will remove the head_evals entry for this
    next unless ($scanner->{conf}->{head_evals}->{$rulename});
    # set score to 0 should also block the rule
    next unless ($scanner->{conf}->{scores}->{$rulename});
    $scanstate->{active_rules}->{$rulename} = 1;
  }

The check on the head_evals will fail since it needs a priority.

I think it would be better to possibly have a method in Conf.pm that
can be used for this sort of thing, pass in a test type, a rulename
and an optional priority.  If no priority is given it will loop over
all of the available priorities trying to find the given rulename.

Michael





------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Reply via email to