-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Theo Van Dinter writes:
> On Fri, May 07, 2004 at 04:36:43AM -0000, [EMAIL PROTECTED] wrote:
> > +      # remove "www.fakehostname.com@" username part
> > +      $host =~ s/[EMAIL PROTECTED]@//gs;
> 
> IMO, get_uri_list shouldn't remove that, that should be up to whoever's 
> calling.

I'm assuming that, like an encoded URL, it should dupe to both an
@ version and an undecoded version.

> > +      # "http://0x7f000001/";
> 
> does http://00000x7f000001/ work?  Just curious.

doesn't seem to, for me.

> > +sub decode_ulong_to_ip {
> > +  my ($ulong) = @_;
> > +  my @octets = ();
> > +  unshift (@octets, $ulong & 0xff); $ulong >>= 8;
> > +  unshift (@octets, $ulong & 0xff); $ulong >>= 8;
> > +  unshift (@octets, $ulong & 0xff); $ulong >>= 8;
> > +  unshift (@octets, $ulong & 0xff);
> > +  return join (".", @octets);
> 
> I don't know which is more efficient, but I always used (converted for
> this function):
> 
> @octets = unpack("CCCC",pack("H*", sprintf "%08lx", $ulong));

sure, hack away ;)  looks likely to be better alright.

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFAm9ViQTcbUG5Y7woRAtQyAJ9W45oCH5x+JX+Rd1+ExPk8YfK3kgCeLtE7
bw5fFE3mcDXMcO2PNZRfLq0=
=HGmA
-----END PGP SIGNATURE-----

Reply via email to