http://bugzilla.spamassassin.org/show_bug.cgi?id=2372





------- Additional Comments From [EMAIL PROTECTED]  2004-05-10 21:58 -------
1) I agree with jm, the Constants module is a good place for it.  two things 
though:

/([\s|\d]\d-[a-zA-Z]{3}-\d{4}\s\d{2}:\d{2}:\d{2}.*),(\d+);([\da-f]{12})-(\w{8})
/o

you don't need the "o" at the end since there's no variable part of the RE.  
also, when making it a constant, be sure to do "$variable =~ RE_CONSTANT" and 
don't put the slashes around it -- this bit us in the Bayes code for a while. :(

2) receive_date moved to Util.pm, fyi.  as for the options, I'd go with (b) as 
well.  we don't want to have parse_rfc822_date doing more than it's supposed to.

anyway, receive_date first looks at received headers, then the mbox seperator 
or 
X-From-Line header, then a few other headers before eventually giving up and 
returning time().  so it's not a biggie.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to