http://bugzilla.spamassassin.org/show_bug.cgi?id=3503
------- Additional Comments From [EMAIL PROTECTED] 2004-06-16 09:48 ------- Subject: Re: [review] local.cf not reread, forced to use @GLOBAL for everything... On Tue, Jun 15, 2004 at 11:00:37PM -0700, [EMAIL PROTECTED] wrote: > > ------- Additional Comments From [EMAIL PROTECTED] 2004-06-15 23:00 ------- > just wondering: is there a reason the config shouldn't be saved for *all* > cases? > I'm worried we're going to miss one this way. > This is a good question. One I'm not completely prepared to answer, Theo would have a much better answer for you I'm sure. Here are a few things off the top of my head: 1) Performance, for the cases where it is not needed it's a performance hit to have to copy/restore the config each time. * Goes off an runs a benchmark...applies patch from 3334 because the problem crops up with the change(which fixes it BTW)...I'm seeing ~8% slowdown when forced to copy/restore for every request (when it isn't necessary) * 2) Requires Storable, which is yet another dependency, but IMHO not one that should be much of a problem, tons of modules these days require Storable. 3) Probably more.... In reality, once you add in all the setuid stuffs, sql-config and ldap-config the remaining use cases are pretty small so perhaps we should turn this on it's head and add a parameter to turn off the copy/restore so folks who know it doesn't affect them can turn it off. Like I said, I'm not totally comfortable with the change and am willing to do something else if it makes more sense. Michael ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
