http://bugzilla.spamassassin.org/show_bug.cgi?id=3506





------- Additional Comments From [EMAIL PROTECTED]  2004-07-27 13:10 -------
Subject: Re:  Occasionally seeing "PSPAMD" returned by spamd 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> What I found was: There really isn't a good reason to use ssize_t. The
> functions that the value ultimately comes from are recv and SSL_read,
> both of which are declared as returning int. ssize_t is not defined on
> all platforms and is not checked for in the configure script, so using
> it requires some messy preprocessor conditionalization. Since both recv
> and SSL_read return int, that's what fd_timeout_read and
> ssl_timeout_read should be declared as returning, bytesread should be
> declared int, the typedefs of ssize_t in utils.c and utils.h can be
> removed, and for good measure the test for bytesread<=0 should come
> before the buf[len]=='\n' test in case there is a timeout when the
> buffer happens to start with a newline, and *lenp should be initialized
> to 0 so it cannot have a bogus value on return from a timeout even if
> the calling code should ignore it in that case.
> 
> And yes, we should try again on EINTR.

all that makes sense to me.  +1 on the plan...

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFBBrafQTcbUG5Y7woRAnEDAKDaHkk05OgUd2pREoObxKqUNsXaYQCfcltN
u5/zTbHddR0kzK2f9dktgzo=
=fGbI
-----END PGP SIGNATURE-----





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to