http://bugzilla.spamassassin.org/show_bug.cgi?id=3631
------- Additional Comments From [EMAIL PROTECTED] 2004-07-28 12:38 ------- Subject: Re: [review] update reserved IP list On Wed, Jul 28, 2004 at 10:33:42AM -0700, [EMAIL PROTECTED] wrote: > Theo, this patch doesn't change behaviour, we don't actually give points for > IPs > that are in the reserved ranges (which I agree is likely to cause FPs in some > wierd setups). instead we just skip them entirely from DNSBL lookups and the Right. SA isn't like a firewall, nothing's going to get blocked, right. However, if the list isn't kept up to date, our behavior will be incorrect wrt the current/new state of the world. I just wanted to mention that I've seen that problem before and we'll need to make sure to keep up on any new allocations which require us to change code. > (a) the reason 192.168, 10, and 172.16 et al are at the top of the old one is > because they are by far the most frequently-encountered reserved ranges; it > adds > a little efficiency. (I don't know if that actually helps though.) I don't know how much of a gain it is, but this is a good point. In perl RE, you want the most common cases at the front since it'll try the or conditions in order. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
