on Sun Jul 29 2007, David Abrahams <dave-UB3wUj7V41K5azolltMz9laTQe2KTcn/-AT-public.gmane.org> wrote:
> My analysis is as follows: HammieFilter.close (in sb_filter.py) jumps through > all sorts of hoops to remember the mode in which the DB was opened, and > avoid calling store() if it was only opened for read. > > def close(self): > if self.h is not None: > if self.mode != 'r': > self.h.store() > self.h.close() > self.h = None > > So it sorta looks like Tony's patch was applied. > > However, Hammie.close (in hammie.py) just barrels ahead and calls > store() unconditionally... > > I'm not sure what the right fix here would be. Keep HammieFilter from > calling Hammie.close() when the DB was not opened for write? Sink the > close/store/mode-checking logic from HammieFilter into Hammie itself? > Something else? I'm happy to submit a patch, but I want to make sure it makes sense. Can I get some guidance about the intended approach, please? Thanks, -- Dave Abrahams Boost Consulting http://www.boost-consulting.com The Astoria Seminar ==> http://www.astoriaseminar.com _______________________________________________ spambayes-dev mailing list spambayes-dev@python.org http://mail.python.org/mailman/listinfo/spambayes-dev
