On Thu, 10 Feb 2005 09:19:28 +0200 (EET) Meelis Roos <[EMAIL PROTECTED]> wrote:
>>> smp_mb(), smp_rmp() and smp_wmb() definitions have a trailing semicolon
>>> and cause compilation errors in single statement context, like
>>> if-then-else on line 358 in include/linux/skbuff.h. This patch removes
>>> all three offending semicolons to make it compile.
>>> Signed-off-by: Meelis Roos <[EMAIL PROTECTED]>
On Thu, Feb 10, 2005 at 12:23:41AM -0800, David S. Miller wrote:
>> Sorry, I should have checked this out when I fixed the same exact
> bug on sparc64.
>> I'll apply and push upstream, thanks.
On Thu, Feb 10, 2005 at 01:41:10AM -0800, William Lee Irwin III wrote:
> Sorry I didn't get around to this. Thanks for taking care of it.
I regenerated the diff by hand because it didn't apply to bk for some
reason, maybe mangled whitespace.
Acked-by: William Irwin <[EMAIL PROTECTED]>
-- wli
smp_mb(), smp_rmp() and smp_wmb() definitions have a trailing semicolon
and cause compilation errors in single statement context, like
if-then-else on line 358 in include/linux/skbuff.h. This patch removes
all three offending semicolons to make it compile.
Signed-off-by: Meelis Roos <[EMAIL PROTECTED]>
===== include/asm-sparc/system.h 1.21 vs edited =====
--- 1.21/include/asm-sparc/system.h Mon Jul 5 03:33:38 2004
+++ edited/include/asm-sparc/system.h Thu Feb 10 11:39:07 2005
@@ -195,9 +195,9 @@
#define read_barrier_depends() do { } while(0)
#define set_mb(__var, __value) do { __var = __value; mb(); } while(0)
#define set_wmb(__var, __value) set_mb(__var, __value)
-#define smp_mb() __asm__ __volatile__("":::"memory");
-#define smp_rmb() __asm__ __volatile__("":::"memory");
-#define smp_wmb() __asm__ __volatile__("":::"memory");
+#define smp_mb() __asm__ __volatile__("":::"memory")
+#define smp_rmb() __asm__ __volatile__("":::"memory")
+#define smp_wmb() __asm__ __volatile__("":::"memory")
#define smp_read_barrier_depends() do { } while(0)
#define nop() __asm__ __volatile__ ("nop");
--
Meelis Roos ([EMAIL PROTECTED])
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
