Tom 'spot' Callaway wrote:
But the cg3 remains stubborn.

I came upon this when comparing the mmap address for cg14 and cg3: cg14.c: .voff = CG3_MMAP_OFFSET, cg3.c: .poff = CG3_MMAP_OFFSET,

I have appended a patch to squash this bug.  But a question remains,
how did this bug go undetected like this?  Either the mmap should
have returned an error, or we should have got a segmentation fault
on writes, but it seems that neither one happened.  Any ideas?

Bob


--- linux-2.6.10-clean/drivers/video/cg3.c 2005-01-12 00:11:02.000000000 -0600 +++ linux-2.6.10/drivers/video/cg3.c 2005-02-11 23:33:54.000000000 -0600 @@ -222,8 +222,8 @@ cg3_blank(int blank, struct fb_info *inf

 static struct sbus_mmap_map cg3_mmap_map[] = {
        {
-               .poff   = CG3_MMAP_OFFSET,
-               .voff   = CG3_RAM_OFFSET,
+               .voff   = CG3_MMAP_OFFSET,
+               .poff   = CG3_RAM_OFFSET,
                .size   = SBUS_MMAP_FBSIZE(1)
        },
        { .size = 0 }
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to