On Wed, 2007-05-23 at 05:03 +0100, Hugh Dickins wrote: > > No, I wasn't meaning the optimization, but the significance of the > boolean __changed that's returned. If ptep_set_access_flags does > not change the pte (because !dirty or !safely_writable or whatever > that arch calls it), then ideally it ought to return false.
Hrm... I prefer keeping the existing semantics. The old code used to always update_mmu_cache() on those archs and I'd rather let it continue do so unless the arch maintainer who knows better changes it :-) > But it doesn't affect correctness if it sometimes says true not > false, and these arches happen to have an empty update_mmu_cache > (with lazy_mmu_prot_update currently under separate review), and > what you have follows what was already being done, and sun4c > already has to "lie": so it's rather theoretical. Ok. Cheers, Ben. - To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
