Nice catch! We'll tidy that up.  

Thanks,

Brian

-----Original Message-----
From: [email protected]
[mailto:[email protected]] On Behalf Of Vasilich
Sent: Wednesday, June 17, 2009 4:38 PM
To: spctools-discuss
Subject: [spctools-discuss] Re: tpp building


Brian,

I am new with this tool and I don't remember where I saw that. Sorry!

Also I am not sure but maybe I found small minor bug in Out2XML
project.

FUNCTION
void Out2XML::writeXMLFooter() {
...
  if (pScanIndex != NULL)
     free(pScanIndex);
}

With my data pScanIndex isn't used at all and, of course, default
value isn't NULL or 0x0. It is something, like 0xcdcdcdcd.

So I would suggest that both constructors
========
Out2XML()
Out2XML(char* path, int topHits, char** argv, int argc)
========
initialize class variables, like

Out2XML(){
     pScanIndex = NULL;
     ...
}

Thank you - Andrei.




--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"spctools-discuss" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/spctools-discuss?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to