That was nearly a week ago - I have been wondering when you are
going to make an effort. So please do it soon.
Anway, there is one typo you really need to fix - in the top level readme,
run: `nosetests`
the backtick ` should be just quotes (' or ")- backticks have specific meanings
in most command shells, and not appropriate here.
Also, I am rather disappointed that there is another indentation error again.
spdx/parsers/tagvaluebuilders.py 779. It is actually three of them:
=================================
def set_file_artifact_of_project_name(self, doc, value):
"""Raises OrderError if no package or file defined.
"""
if self.has_package(doc) and self.has_file(doc):
self.file(doc).artifact_of_project_name.append(value)
else:
raise OrderError('File::AoFProfjectName')
def set_file_artificat_of_project_home(self, doc, value):
"""Raises OrderError if no package or file defined.
"""
if self.has_package(doc) and self.has_file(doc):
self.file(doc).artifact_of_project_home.append(value)
else:
raise OrderError('File::AoFProfjectHome')
def set_file_artificat_of_project_uri(self, doc, value):
"""Raises OrderError if no package or file defined.
"""
if self.has_package(doc) and self.has_file(doc):
self.file(doc).artifact_of_project_uri.append(value)
else:
raise OrderError('File::AoFProfjectUri')
===================================
I wish you have listened. I think I have also told you quite early on to
look up on code-generation functionalities... and try not to
do api one by one by hand. When you find yourself cutting and pasting
three routines which are largely the same, you really should think about
why it is necessary, and ask others for a better way.
code like above can be better written as:
(if you have to do three at all!)
def set_file_artifact_of_project_name(self, doc, value):
return set_file_artifact_of_project(self,doc, "name")
def set_file_artifact_of_project_uri(self, doc, value):
return set_file_artifact_of_project(self,doc, "uri")
def set_file_artifact_of_project_home(self, doc, value):
return set_file_artifact_of_project(self,doc, "home")
def set_file_artifact_of_project(self, doc, value, symbol):
# use eval() to dynamically do
self.file(doc).artifact_of_project_<symbol>.append(value)
# use a lookup-table to switch the error if you have to.
As far as documentation goes, I think you should imagine that
suppose you are going to be killed by a car accident tomorrow,
how soon this work can be picked up by somebody else
and continue? or re-use piece thereof? Or it is better to
just forget about you and your work and re-start from scratch?
--------------------------------------------
On Tue, 24/6/14, ahi <[email protected]> wrote:
Subject: Re: mid-term evaluation
To: [email protected]
Cc: "[email protected]" <[email protected]>, "Philippe
Ombredanne" <[email protected]>, "Nuno Brito" <[email protected]>,
"Vlad Velici" <[email protected]>
Date: Tuesday, 24 June, 2014, 16:58
I am currently writing
the TODO list and setup instructions.
So
does this mean the evaluation will be on the 27th?
Should I prepare a demo of some sort or just
usage instructions?
I am finishing up some
stuff and will be ready with a report this week.
On Tue, Jun 17, 2014 at 1:59 AM, Hin-Tak
Leung
<[email protected]>
wrote:
> You should make all your current
work (in whatever state it is incomplete) available
> in public in the next 10 days, as well as
spend some time, e.g. a day or two, write up enough
> - with build instructions, dependency
requirements, usage instructions - for others
> to try out your code. And write of
what's missing and still to be done, etc.
--
Best Regards,
Ahmed
_______________________________________________
Spdx-tech mailing list
[email protected]
https://lists.spdx.org/mailman/listinfo/spdx-tech
