Hi Gary, Thank you for merging. I will defer to you and the team if new binaries are needed, I have a local build with the fixes, which is sufficient for my purposes.
I have an appointment this afternoon EST, but hope to be able to join the technical team call. Thanks again. Mike From: "[email protected]" <[email protected]> Date: Friday, September 2, 2016 at 8:39 PM To: ms1784 <[email protected]>, "[email protected]" <[email protected]> Subject: RE: SPDX Tools: PREREQUISITE bug? Hi Mike, Thanks for the fixes! They are now merged and pushed back to git.spdx.org. They should be reflected on github within the next hour. Let me know if we should push out new binaries for the fix. Gary From: STAIR, MICHAEL A [mailto:[email protected]] Sent: Friday, September 2, 2016 9:26 AM To: [email protected]; [email protected] Subject: Re: SPDX Tools: PREREQUISITE bug? Hi Gary, Two pull requests pending (one for master, one for spec/2.1). I did not see any existing bug branches for conventions, so used hotfix and bugfix, respectively. I included the license in the comment as directed. Based on the simple nature of this fix, I did not update any unit tests as not to pollute the existing scenarios. Thanks. Mike From: "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Date: Thursday, September 1, 2016 at 10:06 PM To: ms1784 <[email protected]<mailto:[email protected]>>, "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Subject: RE: SPDX Tools: PREREQUISITE bug? Hi Mike, Go ahead and submit a pull request. It may take me a day or so to integrate. Thanks for the fix! Gary From: STAIR, MICHAEL A [mailto:[email protected]] Sent: Thursday, September 1, 2016 2:15 PM To: Gary O'Neall; [email protected]<mailto:[email protected]> Subject: Re: SPDX Tools: PREREQUISITE bug? Thanks Gary, Following CONTRIBUTING.md, I have the fix (for master) on a branch of a fork on github. I can submit a PR if you’d like. Mike From: Gary O'Neall <[email protected]<mailto:[email protected]>> Date: Thursday, September 1, 2016 at 2:58 PM To: ms1784 <[email protected]<mailto:[email protected]>>, "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Subject: Re: SPDX Tools: PREREQUISITE bug? Hi Michael, Looks like a bug in the code to me. I can work on a fix as soon as I get reconnected tonight or tomorrow. Gary On September 1, 2016 12:59:05 PM CDT, "STAIR, MICHAEL A" <[email protected]<mailto:[email protected]>> wrote: Hi, I am using the SPDX tools against a large internal project. I ran into an issue with the PREREQUISITE relationship and after some research believe it is either a bug in the documentation or code (guessing the latter). I opened an issue with more details, https://bugs.linuxfoundation.org/show_bug.cgi?id=1370. Looking for some guidance on: 1. Getting acceptance (ie, it is a bug). 2. Making contributions to the code base (ie, getting it assigned to someone new, me, and making a fix). Thank you. Michael Stair ________________________________ Spdx-tech mailing list [email protected]<mailto:[email protected]> https://lists.spdx.org/mailman/listinfo/spdx-tech -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.
_______________________________________________ Spdx-tech mailing list [email protected] https://lists.spdx.org/mailman/listinfo/spdx-tech
