On Tue, Oct 03, 2017 at 05:05:24PM +0000, Manbeck, Jack via Spdx-tech wrote: > 0BSD-id-good.[c|sh|js| whatever] > 0BSD-id-bad.[c|sh|js| whatever]
To address your “How will people feel about being a "bad" example” [1] I think we want to use match/no-match instead of good/bad [2]. > licenseid/ > licensetext/ > licenseheader/ I don't see a point to repeating “license” in all of these. And I think we'll also want entries for license expressions [2], to allow folks to do things like testing exception grants [3]. Using percent-encoded license expression in the path [2] allows you to handle that without having to say “this directory holds license stuff”. > The testfiles.json directory will contain a json file with the > expected test results… Do we have a canonical JSON SPDX format? If we need an expected-result format at all (for FileCopyrightText and such [4]?), can't we stick to the existing (specified) RDF/XML or tag/value? > Split the spdx and contrib directories for clarity, ease of > maintenance, etc. I don't think we should comingle the files. I think we should have a single directory without an spdx/contrib split. Who suggests a particular test should not be important. What is important is that the package maintainers (whoever they end up being. Legal? Some tech proxies for legal?) have approved all of the tests as accurate representations of the legal team's position on the SPDX expression for the test content [5]. I don't see a point in having a separate “we haven't reviewed these very carefully” directory. Cheers, Trevor [1]: https://github.com/spdx/license-test-files/issues/2#issuecomment-331542559 [2]: https://github.com/spdx/license-test-files/pull/3#issuecomment-331555959 [3]: https://github.com/spdx/license-test-files/issues/2#issuecomment-331510002 [4]: https://github.com/spdx/license-test-files/issues/2#issuecomment-332293578 [5]: https://github.com/spdx/license-test-files/issues/2#issuecomment-331553197 -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Spdx-tech mailing list [email protected] https://lists.spdx.org/mailman/listinfo/spdx-tech
