The current error handling logic in pusb_endpoint_rw_no_timeout is wrong.
(This routine is called indirectly from modem_run when monitoring the state
of the line).  The routine uses the USBDEVFS_REAPURB ioctl on the USB
device to wait for the submitted urb to complete.  If the ioctl returns a
negative (error) result, pusb_endpoint_rw_no_timeout returns it, otherwise it
returns the actual_length of the returned result.  The problem is that the code
acts as if ioctl returning no error means that the urb completed successfully.
If you read the kernel source code (devio.c) you will see that the ioctl returns
an error code if it was unable to get the result of the urb submission.  If the
urb failed because of a stall or some other kind of error, then the error is noted
in the urb's status field, and the urb is returned by the ioctl (which completes
with no error, because it got the result of the urb submission).  So if the ioctl
returns no error, it is then necessary to examine the status field of the urb
to determine if an error occurred or not.  The attached patch does that.

All the best,

Duncan.

PS: This bug bit me.

-- Binary/unsupported file stripped by Listar --
-- Type: text/x-diff
-- File: patch_error.diff


Liste de diffusion modem ALCATEL SpeedTouch USB
Pour se d�sinscrire : mailto:[EMAIL PROTECTED]?subject=unsubscribe

        

Reply via email to