-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 14.01.2011 22:57, schrieb Kevin Dunn: > On Fri, Jan 7, 2011 at 05:17, Georg Brandl <ge...@python.org> wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Am 24.08.2010 15:53, schrieb Kevin Dunn: >>> Hi, >>> >>> I'm developing a Sphinx extension and Django application that I hope >>> to publicly release soon. The extension allows for commenting on each >>> node in the documentation. >>> >>> Docutils makes the starting line number available for each node in the >>> RST file. However, the node's line number is not always propagated for >>> some of the custom Sphinx nodes. >>> >>> It would helpful if the following small patches can be made to: >>> >>> * sphinx/directives/code.py >>> * sphinx/directives/other.py >>> * sphinx/ext/mathbase.py >>> >>> as given by the attached Mercurial diff output against the latest tip. >>> >>> These changes simply ensure that the line number, provided by Docutils >>> via ``self.lineno``, are available in the node object when the various >>> ``visit_ ....`` methods are called later on. The line numbers for >>> most nodes are already available, but these few were not. >> >> This is now committed to 1.0 and trunk. >> >> Thanks, >> Georg > > Hi Georg, > > Thanks for applying my patch. > > However I just noticed that when running on a system that has docutils > version 0.5 that it will break mathematics functionality: any document > that uses the ``.. math::`` directive will raise an error. I've > pasted an example of the Sphinx error below this message. > > It seems that docutils 0.5 does not have a ``.src`` attribute in its > class definition for ``Directive`` (docutils/parsers/rst/__init__.py). > When I supplied that patch I was using docutils version 0.7, which > does have a ``.src`` attribute. > > The obvious solution is to remove a line in my patch:: > > node.source = self.src > > from ``sphinx/ext/mathbase.py``; or to raise the docutils dependency > to a higher version :) > > I apologize for this; I'll be sure to test any future patches on the > minimal Sphinx requirements before submitting them.
Don't apologize, it would be my responsibility just as well as yours. Should be fixed now. Georg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iEYEARECAAYFAk0xX1QACgkQN9GcIYhpnLCagwCgoFT0gBHJ1eX8KINUyr7F3SDN XIQAmwYaLCAag5+DHNIJJrpaK1LNuG/u =qmCl -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "sphinx-dev" group. To post to this group, send email to sphinx-dev@googlegroups.com. To unsubscribe from this group, send email to sphinx-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sphinx-dev?hl=en.
