Hello?
On Wednesday, March 13, 2013 2:14:30 PM UTC+2, Tal Weiss wrote: > > Damn - hard coded AFAICT > > f = open(path.join(self.outdir, '_static', 'pygments.css'), 'w') > > https://bitbucket.org/birkenfeld/sphinx/src/e5c218f45ec783323196473901bd6a14c4ee319a/sphinx/builders/html.py?at=default#cl-558 > > I think this line should be > > f = open(path.join(self.outdir, '_static', 'pygments.css'), 'wb') > > From the Python docs<http://docs.python.org/2/library/functions.html#open>: > Thus, when opening a binary file, you should append 'b' to the mode value > to open the file in binary mode, which will improve portability. (Appending > 'b' is useful even on systems that don’t treat binary and text files > differently, where it serves as documentation.) > > I would add 'b' to the mode of all file open() calls - there are 12 in > this file, of them 4 already have the 'b'. > > > I don't have Mercurial installed - can someone please help me with this pull > request? > > > > Thanks, > > Tal Weiss, > Founder, Evature. > www.evature.com > > On Wed, Mar 13, 2013 at 1:42 PM, Tal Weiss wrote: > >> Ooh - Windows users are using \r\n end of lines! >> Files, such as pygments.py get pingponged between Linux and Windows >> versions! >> >> I wonder if there is anything else. >> And how I remove the carriage returns from the windows builds. >> >> Thanks, >> >> Tal Weiss, >> Founder, Evature. >> www.evature.com >> +972-54-7476276 >> Skype: major.tal >> >> >> On Wed, Mar 13, 2013 at 10:30 AM, Tal Weiss wrote: >> >>> Hi all, >>> >>> I really wish my documents would change only when the actual relevant >>> source files change. >>> Currently they change all the time. >>> I run "make html" as part of my software build process, but I expected >>> the documents to remain the same. >>> Is it because I added the html_last_updated_fmt parameter to the conf.py >>> module (and the date has changed)? >>> Or maybe because some of our developers are using windows (vs. Linux) >>> and the resulting docs are slightly different? >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "sphinx-users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To post to this group, send email to [email protected]. >>> Visit this group at http://groups.google.com/group/sphinx-users?hl=en. >>> For more options, visit https://groups.google.com/groups/opt_out. >>> >>> >>> >> >> > -- You received this message because you are subscribed to the Google Groups "sphinx-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sphinx-users?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
