On Sat, 14 Jul 2007 15:05:59 -0700
David Brownell <[EMAIL PROTECTED]> wrote:
> @@ -115,14 +116,16 @@ struct mmc_host {
> wait_queue_head_t wq;
> unsigned int claimed:1; /* host exclusively claimed */
>
> - struct delayed_work detect;
> + unsigned int use_spi_crc:1;
> +
> #ifdef CONFIG_MMC_DEBUG
> unsigned int removed:1; /* host is being removed */
> #endif
> + unsigned int bus_dead:1; /* bus has been released */
> + struct delayed_work detect;
>
> const struct mmc_bus_ops *bus_ops; /* current bus driver */
> unsigned int bus_refs; /* reference counter */
> - unsigned int bus_dead:1; /* bus has been released */
>
> unsigned long private[0] ____cacheline_aligned;
> };
Some needless shuffling of existing members here.
> @@ -47,6 +52,20 @@ struct mmc_command {
> #define mmc_resp_type(cmd) ((cmd)->flags &
> (MMC_RSP_PRESENT|MMC_RSP_136|MMC_RSP_CRC|MMC_RSP_BUSY|MMC_RSP_OPCODE))
>
> /*
> + * These are the SPI response types for MMC and SD cards (not SDIO).
> + * Commands return R1, with maybe more info. Zero is an error type;
> + * callers must always provide the appropriate MMC_RSP_SPI_Rx flags.
> + */
> +#define MMC_RSP_SPI_R1 (MMC_RSP_SPI_S1)
> +#define MMC_RSP_SPI_R1B (MMC_RSP_SPI_S1|MMC_RSP_BUSY)
I think it's probably safe to keep the two response types separate, even though
it is very unlikely that we'll have a command that only uses busy signalling in
one of the modes.
Other than that, it looks fine.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
