On Monday 06 August 2007, Anton Vorontsov wrote: > + > + if (pm) > + pm--; > + else /* this floods dmesg if using mmc_spi, so dbg */ > + dev_dbg(&spi->dev, "Requested speed is too " > + "high: %d Hz. Will use %d Hz > instead.\n", > + spi->max_speed_hz, > mpc83xx_spi->spibrg / 4);
Except that's not worthy of any message whatsoever, so it shouldn't even be a debug message: user says "give me at most X", driver says "fine", end of story. I'm more bothered by the earlier message, which gives a rate higher than X instead of cleanly failing. - Dave ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
